From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 6 Apr 2015 11:39:50 -0700 From: Jacob Pan To: Jonathan Cameron Cc: IIO , LKML , Lee Jones , Lars-Peter Clausen , Hartmut Knaack , Aaron Lu , Todd Brandt Subject: Re: [PATCH] iio/axp288_adc: add missing channel info mask Message-ID: <20150406113950.3ebfa694@icelake> In-Reply-To: <550D5EE7.20208@kernel.org> References: <1426527265-14979-1-git-send-email-jacob.jun.pan@linux.intel.com> <550D5EE7.20208@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-ID: On Sat, 21 Mar 2015 12:07:03 +0000 Jonathan Cameron wrote: > > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) > > + | BIT(IIO_CHAN_INFO_RAW), > > }, > These cases strike me as problematic. You should not need both. If > the consumer is reading _raw from a channel that only supplies > PROCESSED then that is the bug, not the lack of support for a raw > read. > > }; Very sorry about the delay, you are right that we should just need RAW. V2 patch just sent. Thanks, Jacob