linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Xander Huff <xander.huff@ni.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, michal.simek@xilinx.com,
	soren.brinkmann@xilinx.com, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rt-users@vger.kernel.org, ben.shelton@ni.com,
	joe.hershberger@ni.com, joshc@ni.com
Subject: Re: [PATCH] iio: adc: xilinx-xadc: Convert to raw spinlock
Date: Thu, 14 May 2015 19:10:38 +0200	[thread overview]
Message-ID: <20150514171038.GG13442@linutronix.de> (raw)
In-Reply-To: <1431013090-18996-1-git-send-email-xander.huff@ni.com>

* Xander Huff | 2015-05-07 10:38:10 [-0500]:

>The driver currently registers a pair of irq handlers using
>request_threaded_irq(), however the synchronization mechanism
>between the hardirq and the threadedirq handler is a regular spinlock.
>
>Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can
>sleep, and is thus not able to be acquired from a hardirq handler.
>Because the set of operations performed under the spinlock is already
>minimal and bounded, it is a suitable candidate for being a raw_spinlock.
>
>This patch should not impact behavior on !PREEMPT_RT builds.
>
>Signed-off-by: Xander Huff <xander.huff@ni.com>
>Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
>Reviewed-by: Ben Shelton <ben.shelton@ni.com>
>Reviewed-by: Josh Cartwright <joshc@ni.com>

Do you have any cyclictest numbers how much the latency increases on
heavy iio usage? Traditionally the primary handler should be very quick
/ short.

Sebastian

  reply	other threads:[~2015-05-14 17:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 15:38 [PATCH] iio: adc: xilinx-xadc: Convert to raw spinlock Xander Huff
2015-05-14 17:10 ` Sebastian Andrzej Siewior [this message]
2015-05-14 22:45   ` Xander Huff
2015-05-18 21:17     ` Sebastian Andrzej Siewior
2015-05-23 11:36       ` Jonathan Cameron
2015-06-07 15:29       ` Jonathan Cameron
2015-06-08 14:44         ` Xander Huff
2015-07-08 21:38         ` [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context Xander Huff
2015-07-09  5:03           ` Shubhrajyoti Datta
2015-07-15 15:57             ` Xander Huff
2015-07-20 23:14             ` [PATCH v3] " Xander Huff
2015-07-24 12:38               ` Lars-Peter Clausen
2015-08-03 20:18                 ` Xander Huff
2015-08-04  8:01                   ` Lars-Peter Clausen
2015-08-11 23:00                     ` [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff
2015-08-12 15:17                       ` Lars-Peter Clausen
2015-08-12 16:33                         ` Sebastian Andrzej Siewior
2015-08-15 19:55                           ` Jonathan Cameron
2015-08-04  5:34                 ` [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context Shubhrajyoti Datta
2015-08-04  8:05                   ` Lars-Peter Clausen
2015-08-07  3:55                     ` Shubhrajyoti Datta
2015-07-14 14:28           ` [PATCH v2] " Sebastian Andrzej Siewior
2015-07-15 15:59             ` Xander Huff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514171038.GG13442@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=ben.shelton@ni.com \
    --cc=jic23@kernel.org \
    --cc=joe.hershberger@ni.com \
    --cc=joshc@ni.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=pmeerw@pmeerw.net \
    --cc=soren.brinkmann@xilinx.com \
    --cc=xander.huff@ni.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).