From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 May 2015 12:35:28 +0300 From: Dan Carpenter To: Daniel Baluta Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Tiberiu Breana , "linux-iio@vger.kernel.org" , kernel-janitors@vger.kernel.org Subject: Re: [patch] iio: light: signedness bug in stk3310_write_raw() Message-ID: <20150527093528.GG11734@mwanda> References: <20150527082425.GB19423@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Wed, May 27, 2015 at 12:31:26PM +0300, Daniel Baluta wrote: > On Wed, May 27, 2015 at 11:24 AM, Dan Carpenter > wrote: > > "index" needs to be signed for the error handling to work. > > > > Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310') > > Signed-off-by: Dan Carpenter > > Hi Dan, > > Did you find this with a tool? Yeah. This is a Smatch thing. regards, dan carpenter