From: Vladimirs Ambrosovs <rodriguez.twister@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: jic23@kernel.org, daniel.baluta@intel.com,
dan.carpenter@oracle.com, gregkh@linuxfoundation.org,
cristina.opriceana@gmail.com, linux-iio@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH v2 2/3] staging: iio_simple_dummy: fix return types
Date: Sat, 30 May 2015 10:07:17 +0300 [thread overview]
Message-ID: <20150530070717.GA32531@gmail.com> (raw)
In-Reply-To: <20150530065442.GG31685@sudip-PC>
On Sat, May 30, 2015 at 12:24:42PM +0530, Sudip Mukherjee wrote:
> On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote:
> > The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
> > iio_dummy_evgen_release_irq() were changed to return void instead of int,
> > because these functions always return 0.
> >
> > Signed-off-by: Vladimirs Ambrosovs <rodriguez.twister@gmail.com>
> oops. it breaks the build.
>
> drivers/staging/iio/iio_simple_dummy_events.c:260:6: error: conflicting types for ‘iio_simple_dummy_events_unregister’
> In file included from drivers/staging/iio/iio_simple_dummy_events.c:18:0:
> drivers/staging/iio/iio_simple_dummy.h:82:5: note: previous declaration of ‘iio_simple_dummy_events_unregister’ was here
>
> drivers/staging/iio/iio_dummy_evgen.c:131:6: error: conflicting types for ‘iio_dummy_evgen_release_irq’
> In file included from drivers/staging/iio/iio_dummy_evgen.c:24:0:
> drivers/staging/iio/iio_dummy_evgen.h:11:5: note: previous declaration of ‘iio_dummy_evgen_release_irq’ was here
>
> drivers/staging/iio/iio_dummy_evgen.c:137:1: error: conflicting types for ‘iio_dummy_evgen_release_irq’
> In file included from drivers/staging/iio/iio_dummy_evgen.c:24:0:
> drivers/staging/iio/iio_dummy_evgen.h:11:5: note: previous declaration of ‘iio_dummy_evgen_release_irq’ was here
>
> regards
> sudip
Oops, that's embarassing... Sure, I did check it..
Thanks Sudip, will fix it.
BR,
Vladimirs
next prev parent reply other threads:[~2015-05-30 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 21:45 [PATCH v2 0/3] staging: iio_simple_dummy: minor driver fixes Vladimirs Ambrosovs
2015-05-29 21:45 ` [PATCH v2 1/3] staging: iio_simple_dummy: fix init function Vladimirs Ambrosovs
2015-05-29 21:45 ` [PATCH v2 2/3] staging: iio_simple_dummy: fix return types Vladimirs Ambrosovs
2015-05-30 6:54 ` Sudip Mukherjee
2015-05-30 7:07 ` Vladimirs Ambrosovs [this message]
2015-05-29 21:45 ` [PATCH v2 3/3] staging: iio_simple_dummy: fix module_param type Vladimirs Ambrosovs
2015-05-30 5:03 ` [PATCH v2 0/3] staging: iio_simple_dummy: minor driver fixes Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530070717.GA32531@gmail.com \
--to=rodriguez.twister@gmail.com \
--cc=cristina.opriceana@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@intel.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).