From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Tiberiu Breana <tiberiu.a.breana@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
kernel@pengutronix.de, Alexandre Courbot <gnurou@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: stk3310: use flags argument of devm_gpiod_get
Date: Sat, 13 Jun 2015 21:11:40 +0200 [thread overview]
Message-ID: <20150613191140.GX18985@pengutronix.de> (raw)
In-Reply-To: <557C7125.3010606@kernel.org>
Hello Jonathan,
On Sat, Jun 13, 2015 at 07:06:29PM +0100, Jonathan Cameron wrote:
> On 12/06/15 08:51, Uwe Kleine-König wrote:
> > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> > which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> > parameter that allows to specify direction and initial value for output.
> >
> > Simplify driver accordingly. Furthermore this is one caller less that
> > stops us making the flags argument to gpiod_get*() mandatory.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
> > ---
> > Hello,
> >
> > this patch applies to next and is only necessary on top of 3dd477acbdd1
> > (iio: light: Add threshold interrupt support for STK3310) which
> > currently sits in next.
> >
> > Note I plan to make the flags parameter mandatory for 4.3. So unless
> > this change gets into 4.2, would it be ok to let it go in via the gpio
> > tree?
> yes, that's fine.
that means you won't take it for 4.2, right?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-06-13 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 7:51 [PATCH] iio: light: stk3310: use flags argument of devm_gpiod_get Uwe Kleine-König
2015-06-13 18:06 ` Jonathan Cameron
2015-06-13 19:11 ` Uwe Kleine-König [this message]
2015-06-13 20:47 ` Jonathan Cameron
2015-06-15 8:16 ` Linus Walleij
2015-06-15 8:35 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150613191140.GX18985@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gnurou@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tiberiu.a.breana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox