From: Marek Vasut <marex@denx.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
devel@driverdev.osuosl.org,
Fabio Estevam <fabio.estevam@freescale.com>,
linux-iio@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names
Date: Mon, 20 Jul 2015 00:06:11 +0200 [thread overview]
Message-ID: <201507200006.11989.marex@denx.de> (raw)
In-Reply-To: <20150719204947.GG5371@mwanda>
On Sunday, July 19, 2015 at 10:49:47 PM, Dan Carpenter wrote:
> On Sun, Jul 19, 2015 at 11:33:43PM +0300, Dan Carpenter wrote:
> > I didn't necessarily read the thread that way, but the thread was
> > long...
>
> I read the thread as saying that you sometimes get:
>
> Reviewed-by: Some Person <email@bigcompany.com>
Hm, I'm trying to use this email as a single point-of-presence, but
maybe I should start separating reviews I do in my free time and
send my R-B and A-B from my private address ?
> With no other comments and what does that even mean because you don't
> know who that person is and if they are good at reviewing. There isn't
> a solution to that. But since we know Marek then that doesn't really
> apply here. Also people were worried that companies were going to start
> counting Reviewed-by tags so we should discourage that.
Uh, OK, I wasn't aware of this.
> Anyway, I don't see Reviewed-by tags as a reward, only as added
> responsibility.
Yeah, that's a good point. If you review code and it turns out to be crap,
then the value of your R-B and A-B decreases.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-07-19 22:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 12:30 [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names Stefan Wahren
2015-07-18 12:30 ` [PATCH 1/6] iio: mxs-lradc: clarify supported devices Stefan Wahren
2015-07-19 9:32 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 2/6] iio: mxs-lradc: fix some spelling errors Stefan Wahren
2015-07-19 9:33 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 3/6] iio: mxs-lradc: add missing include Stefan Wahren
2015-07-19 9:34 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 4/6] iio: mxs-lradc: remove unnecessary header includes Stefan Wahren
2015-07-19 9:35 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 5/6] iio: mxs-lradc: reorder " Stefan Wahren
2015-07-18 15:37 ` Marek Vasut
2015-07-19 9:37 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 6/6] iio: mxs-lradc: add datasheet name for every usable channel Stefan Wahren
2015-07-19 9:40 ` Jonathan Cameron
2015-07-18 15:38 ` [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names Marek Vasut
2015-07-19 9:45 ` Jonathan Cameron
2015-07-19 20:33 ` Dan Carpenter
2015-07-19 20:49 ` Dan Carpenter
2015-07-19 21:44 ` Jonathan Cameron
2015-07-19 22:06 ` Marek Vasut [this message]
2015-07-20 7:00 ` Dan Carpenter
2015-07-20 8:16 ` Marek Vasut
2015-07-19 21:08 ` Jonathan Cameron
2015-07-19 22:11 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201507200006.11989.marex@denx.de \
--to=marex@denx.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).