From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Vasut To: Dan Carpenter Subject: Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names Date: Mon, 20 Jul 2015 00:06:11 +0200 Cc: Jonathan Cameron , Stefan Wahren , devel@driverdev.osuosl.org, Fabio Estevam , linux-iio@vger.kernel.org, "Greg Kroah-Hartman" , "Lars-Peter Clausen" , Peter Meerwald , Hartmut Knaack References: <1437222646-8742-1-git-send-email-stefan.wahren@i2se.com> <20150719203343.GF5371@mwanda> <20150719204947.GG5371@mwanda> In-Reply-To: <20150719204947.GG5371@mwanda> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Message-Id: <201507200006.11989.marex@denx.de> List-ID: On Sunday, July 19, 2015 at 10:49:47 PM, Dan Carpenter wrote: > On Sun, Jul 19, 2015 at 11:33:43PM +0300, Dan Carpenter wrote: > > I didn't necessarily read the thread that way, but the thread was > > long... > > I read the thread as saying that you sometimes get: > > Reviewed-by: Some Person Hm, I'm trying to use this email as a single point-of-presence, but maybe I should start separating reviews I do in my free time and send my R-B and A-B from my private address ? > With no other comments and what does that even mean because you don't > know who that person is and if they are good at reviewing. There isn't > a solution to that. But since we know Marek then that doesn't really > apply here. Also people were worried that companies were going to start > counting Reviewed-by tags so we should discourage that. Uh, OK, I wasn't aware of this. > Anyway, I don't see Reviewed-by tags as a reward, only as added > responsibility. Yeah, that's a good point. If you review code and it turns out to be crap, then the value of your R-B and A-B decreases. Best regards, Marek Vasut