From: Matt Porter <mporter@konsulko.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Linux IIO List <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver
Date: Thu, 6 Aug 2015 13:38:44 -0400 [thread overview]
Message-ID: <20150806173844.GI23173@beef> (raw)
In-Reply-To: <alpine.DEB.2.02.1508032313380.17732@pmeerw.net>
On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote:
> On Mon, 3 Aug 2015, Matt Porter wrote:
...
> > +static int max6675_read(struct max6675_state *st, int *val)
> > +{
> > + int ret;
> > +
> > + ret = spi_read(st->spi, val, 2);
> > + if (ret < 0)
> > + return ret;
> > +
> > + /* Temperature is bits 14..3 */
> > + *val = (*val >> 3) & 0xfff;
>
> what about endianness conversion?
> use be16_to_cpu()
Apologies, I spoke before engaging the brain on my first reply to this
As specified by the SPI subsystem docs, SPI buffers are always stored
in native endian order. There is no need for endianness conversion here.
-Matt
next prev parent reply other threads:[~2015-08-06 17:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 20:56 [PATCH 0/3] MAX6675 IIO temperature driver Matt Porter
2015-08-03 20:56 ` [PATCH 1/3] iio: temperature: add max6675 dt binding Matt Porter
2015-08-03 20:56 ` [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver Matt Porter
2015-08-03 21:26 ` Peter Meerwald
2015-08-03 23:13 ` Matt Porter
2015-08-06 17:38 ` Matt Porter [this message]
2015-08-08 11:39 ` Jonathan Cameron
2015-08-20 0:23 ` Matt Porter
2015-08-23 15:44 ` Jonathan Cameron
2015-08-03 22:39 ` Matt Ranostay
2015-08-03 23:10 ` Matt Porter
2015-08-04 7:50 ` Daniel Baluta
2015-08-04 13:01 ` Matt Porter
2015-08-04 9:30 ` Paul Bolle
2015-08-04 13:18 ` Matt Porter
2015-08-03 20:56 ` [PATCH 3/3] MAINTAINERS: add max6675 driver Matt Porter
2015-08-04 16:52 ` [PATCH 0/3] MAX6675 IIO temperature driver Jonathan Cameron
2015-08-04 17:34 ` Matt Porter
2015-08-05 8:33 ` Daniel Baluta
2015-08-05 11:43 ` Matt Porter
2015-08-08 11:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806173844.GI23173@beef \
--to=mporter@konsulko.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).