From: Mark Rutland <mark.rutland@arm.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Martin Kepplinger <martink@posteo.de>,
robh+dt@kernel.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net,
mfuzzey@parkeon.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
Subject: Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins
Date: Thu, 15 Oct 2015 11:20:37 +0100 [thread overview]
Message-ID: <20151015102037.GB8825@leverpostej> (raw)
In-Reply-To: <561E70E0.1010508@metafoo.de>
On Wed, Oct 14, 2015 at 05:12:32PM +0200, Lars-Peter Clausen wrote:
> On 10/14/2015 03:15 PM, Martin Kepplinger wrote:
> [...]
> > + if (irq1 > 0)
> > + client->irq = irq1;
>
> You must not overwrite client->irq, that field is manged by the I2C core and
> is supposed to be read only for device drivers.
Ok.
I think for the moment the simlpest thing to do would be to check which
of INT1 and INT2 match client->irq, and use that.
Thanks,
Mark.
prev parent reply other threads:[~2015-10-15 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 13:15 [PATCH v3] iio: mma8452: support either of the available interrupt pins Martin Kepplinger
2015-10-14 15:12 ` Lars-Peter Clausen
2015-10-15 9:32 ` Martin Kepplinger
2015-10-15 10:14 ` Mark Rutland
2015-10-15 10:20 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015102037.GB8825@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@theobroma-systems.com \
--cc=martink@posteo.de \
--cc=mfuzzey@parkeon.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox