Linux IIO development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PULL] IIO - First set of new drivers, core support and cleanups for the 4.5 cycle
Date: Tue, 1 Dec 2015 09:13:56 -0800	[thread overview]
Message-ID: <20151201171356.GC2714@kroah.com> (raw)
In-Reply-To: <5651D1DA.9020903@kernel.org>

On Sun, Nov 22, 2015 at 02:31:54PM +0000, Jonathan Cameron wrote:
> 
> Hi Greg,
> 
> When this one and the fixes set I sent a few minutes ago merge you curiously
> get an issue with drivers/staging/iio/Kconfig.  The right resolution is
> to dump all the dummy driver stuff.
> 
> All the other changes related to that move and various automerge stuff that
> occurs looks fine to me.

Thanks for the merge info, that helped.

But, I'm now getting these build warnings that I don't think we had
before:

drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_complete_touch_event’:
drivers/staging/iio/adc/mxs-lradc.c:325:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     (((x) << LRADC_DELAY_TRIGGER_LRADCS_OFFSET) & \
     ^
drivers/staging/iio/adc/mxs-lradc.c:734:7: note: in expansion of macro ‘LRADC_DELAY_TRIGGER’
       LRADC_DELAY_TRIGGER(1 << TOUCHSCREEN_VCHANNEL1) |
       ^
  LD [M]  drivers/staging/iio/accel/adis16201.o
drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_preenable’:
drivers/staging/iio/adc/mxs-lradc.c:322:42: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define LRADC_DELAY_TRIGGER_LRADCS_MASK  (0xff << 24)
                                          ^
drivers/staging/iio/adc/mxs-lradc.c:1308:29: note: in expansion of macro ‘LRADC_DELAY_TRIGGER_LRADCS_MASK’
  mxs_lradc_reg_clear(lradc, LRADC_DELAY_TRIGGER_LRADCS_MASK |
                             ^
drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_postdisable’:
drivers/staging/iio/adc/mxs-lradc.c:322:42: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define LRADC_DELAY_TRIGGER_LRADCS_MASK  (0xff << 24)
                                          ^
drivers/staging/iio/adc/mxs-lradc.c:1327:29: note: in expansion of macro ‘LRADC_DELAY_TRIGGER_LRADCS_MASK’
  mxs_lradc_reg_clear(lradc, LRADC_DELAY_TRIGGER_LRADCS_MASK |
                             ^

Can you fix those up?

thanks,

greg k-h

  parent reply	other threads:[~2015-12-01 17:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 14:26 [PULL] IIO - First set of new drivers, core support and cleanups for the 4.5 cycle Jonathan Cameron
2015-11-22 14:31 ` Jonathan Cameron
2015-11-29 17:29   ` Jonathan Cameron
2015-12-01  3:59     ` Greg KH
2015-12-01  7:13       ` Jonathan Cameron
2015-12-01 17:13   ` Greg KH [this message]
2015-12-01 20:54     ` Jonathan Cameron
2015-12-01 21:39       ` Lars-Peter Clausen
2015-12-01 22:05         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201171356.GC2714@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox