From: Marek Vasut <marex@denx.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
marxin.liska@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: acpi-als: Report data as processed rather than raw
Date: Sat, 9 Jan 2016 18:27:50 +0100 [thread overview]
Message-ID: <201601091827.50571.marex@denx.de> (raw)
In-Reply-To: <569135DC.2090400@kernel.org>
On Saturday, January 09, 2016 at 05:31:24 PM, Jonathan Cameron wrote:
> On 07/01/16 15:21, Gabriele Mazzotta wrote:
> > As per the ACPI specification (Revision 5.0) [1], the data coming
> > from the sensor represent the ambient light illuminance reading
> > expressed in lux. Use IIO_CHAN_INFO_PROCESSED instead of
> > IIO_CHAN_INFO_RAW to signify that the data are pre-processed.
> >
> > [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
> >
> > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
>
> Hm. Whilst it's a fix in a sense, the original didn't really 'break'
> the ABI so I worry a little that this change may break others.
> Irritating as it is, perhaps we should keep the _RAW and add _PROCESSED
> (which will then be exactly the same value).
> We'll also then need a comment in the code, that leaving the _RAW
> elements was for ABI compatibility.
>
> What do others think?
I'm not an IIO guru, but this does sound sensible. Do you know if any userland
code which actually uses the ACPI ALS already ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-09 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 15:21 [PATCH] iio: light: acpi-als: Report data as processed rather than raw Gabriele Mazzotta
2016-01-09 16:31 ` Jonathan Cameron
2016-01-09 17:27 ` Marek Vasut [this message]
2016-01-11 19:18 ` Jonathan Cameron
2016-01-11 19:20 ` Marek Vasut
2016-01-12 0:15 ` Gabriele Mazzotta
2016-01-12 15:27 ` Gabriele Mazzotta
2016-01-16 12:57 ` Jonathan Cameron
2016-01-11 10:16 ` Crt Mori
2016-01-11 19:15 ` Jonathan Cameron
2016-01-12 15:21 ` [PATCH v2] iio: light: acpi-als: Report data as processed Gabriele Mazzotta
2016-01-16 13:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601091827.50571.marex@denx.de \
--to=marex@denx.de \
--cc=gabriele.mzt@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marxin.liska@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).