From: Ondrej Zary <linux@rainbow-software.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: "Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
Cristina Moraru <cristina.moraru09@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Ludovic Tancerel <ludovic.tancerel@maplehightech.com>,
Matt Ranostaj <mranostay@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"octavian.purdila@intel.com" <octavian.purdila@intel.com>
Subject: Re: [PATCH] iio: Add TH06 Humidity and Temperature sensor driver
Date: Tue, 12 Jan 2016 13:50:10 +0100 [thread overview]
Message-ID: <201601121350.11076.linux@rainbow-software.org> (raw)
In-Reply-To: <CAEnQRZBUkaFKLUZRQD3zDU4JyHbrBd+dv+vuZwMf5zjqogBijQ@mail.gmail.com>
On Tuesday 12 January 2016, Daniel Baluta wrote:
> On Tue, Jan 12, 2016 at 1:07 PM, Peter Meerwald-Stadler
>
> <pmeerw@pmeerw.net> wrote:
> >> Add implementation for Hoperf TH06 Humidity and Temperature
> >> sensor driver.
> >>
> >> Datasheet: http://www.hoperf.com/upload/sensor/TH06_Module_v01.pdf
> >
> > I think it would be good to make to manufacturer's company name (Hoperf)
> > more visible in the driver; it is currently just mentioned in the commit
> > message; just 'TH06' is hard to google :)
> >
> > maybe you could list the TODOs / unsupported features here...
> >
> > the I2C register layout looks close to the si7020, maybe the chip can be
> > supported there without duplicating code?
>
> Yes, they look pretty similar. We can give it a try to add the support
> for TH06 into
> already existing code for si7020.
>
> There will be some fun with Kconfig part :). Any idea if Hoperf and
> Silabs are related
> companies :D.
Looks like TH06 is just a module with Si7020 chip. Try the "Read Electronic
ID" and "Read Firmware Revision" commands from Si7020 datasheet.
--
Ondrej Zary
prev parent reply other threads:[~2016-01-12 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 22:57 [PATCH] iio: Add TH06 Humidity and Temperature sensor driver Cristina Moraru
2016-01-12 11:07 ` Peter Meerwald-Stadler
2016-01-12 12:12 ` Daniel Baluta
2016-01-12 12:50 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601121350.11076.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=cristina.moraru09@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.tancerel@maplehightech.com \
--cc=mranostay@gmail.com \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).