From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Gujulan Elango, Hari Prasath (H.)" To: Matt Ranostay CC: "gregkh@linuxfoundation.org" , "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "daniel.baluta@intel.com" , "ciorneiioana@gmail.com" , "hamohammed.sa@gmail.com" , "devel@driverdev.osuosl.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get() Date: Fri, 22 Jan 2016 07:31:55 +0000 Message-ID: <20160122073258.GB10350@IND12F0122> References: <20160121091238.GA9430@IND12F0122> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote: > On Thu, Jan 21, 2016 at 1:11 AM, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch replaces the clk_get() with devm_clk_get(). > > Accordingly,modified the error paths and removed clk_put() as well. > > > > Signed-off-by: Hari Prasath Gujulan Elango > > --- > > drivers/staging/iio/adc/spear_adc.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/spear_adc.c b/drivers/staging/iio/= adc/spear_adc.c > > index 712cae0..4ac0f54 100644 > > --- a/drivers/staging/iio/adc/spear_adc.c > > +++ b/drivers/staging/iio/adc/spear_adc.c > > @@ -288,7 +288,7 @@ static int spear_adc_probe(struct platform_device *= pdev) > > st->adc_base_spear3xx =3D > > (struct adc_regs_spear3xx __iomem *)st->adc_base_spear6= xx; > > > > - st->clk =3D clk_get(dev, NULL); > > + st->clk =3D devm_clk_get(dev, NULL); > > if (IS_ERR(st->clk)) { > > dev_err(dev, "failed getting clock\n"); > > goto errout1; > > @@ -297,7 +297,7 @@ static int spear_adc_probe(struct platform_device *= pdev) > > ret =3D clk_prepare_enable(st->clk); > > if (ret) { > > dev_err(dev, "failed enabling clock\n"); > > - goto errout2; > > + goto errout1; > > } > > > > irq =3D platform_get_irq(pdev, 0); > > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *= pdev) > > > > errout3: > > clk_disable_unprepare(st->clk); >=20 > Shouldn't errout3 now be errout2.. having a gap would seem odd. >=20 I agree with you on this. But as Dan says,I would correct it in a different patch. > > -errout2: > > - clk_put(st->clk); > > errout1: > > iounmap(st->adc_base_spear6xx); > > return ret; > > -- > > 1.9.1=