From: Michael Welling <mwelling@ieee.org>
To: Adriana Reus <adriana.reus@intel.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
srinivas.pandruvada@linux.intel.com, ggao@invensense.com,
lucas.de.marchi@gmail.com
Subject: Re: [PATCH v2 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality
Date: Sun, 7 Feb 2016 20:31:05 -0600 [thread overview]
Message-ID: <20160208023105.GA12090@deathstar> (raw)
In-Reply-To: <1454577628-12708-1-git-send-email-adriana.reus@intel.com>
On Thu, Feb 04, 2016 at 11:20:24AM +0200, Adriana Reus wrote:
> This series splits this driver into general and I2C/SPI specific functionality.
> The first patch is a fix for a bug in the interrupt pin configuration.
> The second patch changes all the I2C specific calls into regmap calls.
> The third patch separated the remaining I2C specific part into a different component.
> Finally the fourth patch adds SPI support for the MPU6000 chip.
>
> No changes since v1 for the first two patches.
> Small changes since v1 to the last two patches
>
> Adriana Reus (4):
> iio: imu: inv-mpu6050: Fix interrupt pin configuration
> iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions
> iio: imu: inv_mpu6050: Separate driver into core and i2c
> functionality.
> iio: imu: inv_mpu6050: Add SPI support for MPU6000
>
> drivers/iio/imu/inv_mpu6050/Kconfig | 21 ++-
> drivers/iio/imu/inv_mpu6050/Makefile | 8 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 14 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 253 +++++---------------------
> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 207 +++++++++++++++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 17 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 35 ++--
> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 87 +++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 10 +-
> 9 files changed, 412 insertions(+), 240 deletions(-)
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c
>
Got the following when compiling for a non ACPI target.
/home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c:205:5: error: conflicting types for 'inv_mpu_acpi_create_mux_client'
int inv_mpu_acpi_create_mux_client(struct inv_mpu6050_state *st)
^
In file included from /home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c:203:0:
/home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h:261:5: note: previous declaration of 'inv_mpu_acpi_create_mux_client' was here
int inv_mpu_acpi_create_mux_client(struct i2c_client *client);
^
/home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c:210:6: error: conflicting types for 'inv_mpu_acpi_delete_mux_client'
void inv_mpu_acpi_delete_mux_client(struct inv_mpu6050_state *st)
^
In file included from /home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c:203:0:
/home/michael/projects/linux/linux-git/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h:262:6: note: previous declaration of 'inv_mpu_acpi_delete_mux_client' was here
void inv_mpu_acpi_delete_mux_client(struct i2c_client *client);
Seems a few function definitions on the other side of the ifdef were missed.
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-08 2:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 9:20 [PATCH v2 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Adriana Reus
2016-02-04 9:20 ` [PATCH v2 1/4] iio: imu: inv-mpu6050: Fix interrupt pin configuration Adriana Reus
2016-02-04 9:20 ` [PATCH v2 2/4] iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions Adriana Reus
2016-02-04 9:20 ` [PATCH v2 3/4] iio: imu: inv_mpu6050: Separate driver into core and i2c functionality Adriana Reus
2016-02-08 2:06 ` Michael Welling
2016-02-09 20:08 ` Lars-Peter Clausen
2016-02-04 9:20 ` [PATCH v2 4/4] iio: imu: inv_mpu6050: Add SPI support for MPU6000 Adriana Reus
2016-02-05 19:29 ` Lucas De Marchi
2016-02-08 2:05 ` Michael Welling
2016-02-09 20:11 ` Lars-Peter Clausen
2016-02-05 12:40 ` [PATCH v2 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Daniel Baluta
2016-02-08 2:31 ` Michael Welling [this message]
2016-02-08 7:16 ` Michael Welling
2016-02-09 8:39 ` Adriana Reus
2016-02-09 15:45 ` Michael Welling
2016-02-09 16:30 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208023105.GA12090@deathstar \
--to=mwelling@ieee.org \
--cc=adriana.reus@intel.com \
--cc=ggao@invensense.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).