From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f195.google.com ([209.85.213.195]:36595 "EHLO mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbcBJQgm (ORCPT ); Wed, 10 Feb 2016 11:36:42 -0500 Date: Wed, 10 Feb 2016 10:36:22 -0600 From: Michael Welling To: Sricharan Cc: 'Daniel Baluta' , 'Wolfram Sang' , 'Jonathan Cameron' , 'Hartmut Knaack' , 'Lars-Peter Clausen' , 'Peter Meerwald-Stadler' , 'Linux Kernel Mailing List' , linux-iio@vger.kernel.org, 'Lucas De Marchi' , 'Andy Gross' , 'Pramod Gurav' , 'Bjorn Andersson' , 'Guenter Roeck' , eibach@gdsys.de, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Message-ID: <20160210163622.GA1390@deathstar> References: <20160205172457.GA16778@deathstar> <20160206003245.GA1329@deathstar> <20160208102459.GC2220@tetsubishi> <20160208163632.GA3630@deathstar> <01fd01d162a4$8e28c450$aa7a4cf0$@codeaurora.org> <20160208191658.GA23145@deathstar> <001b01d163fd$bfb15280$3f13f780$@codeaurora.org> <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > Hi Sricharan, > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c > > right? > > > Yes. > > > I'm asking this because this driver doesn't seem to support runtime pm and > > there is no check for regmap_write/regmap_write return code in the probe > > function. > Hmm to be clear, so it’s the pm_runtime_getsync from i2c-qup which fails right ? > I was tracking that when there are i2c_xfers from pwm. I did not see any failures there. > So wanted to know the correct sequence to reproduce. > The problem was discovered using the patch that this thread is on. The PWM driver does not have the problem. When the driver in this patch called pm_runtime_get_sync you got -EINVAL back. > Regards, > Sricharan > > >