From: Michael Welling <mwelling@ieee.org>
To: Adriana Reus <adriana.reus@intel.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
srinivas.pandruvada@linux.intel.com, ggao@invensense.com,
lars@metafoo.de, daniel.baluta@intel.com,
lucas.de.marchi@gmail.com, adi.reus@gmail.com, cmo@melexis.com
Subject: Re: [PATCH v5 3/4] iio: imu: inv_mpu6050: Separate driver into core and i2c functionality.
Date: Thu, 11 Feb 2016 12:00:20 -0600 [thread overview]
Message-ID: <20160211180019.GA15330@deathstar> (raw)
In-Reply-To: <1455185128-4717-4-git-send-email-adriana.reus@intel.com>
On Thu, Feb 11, 2016 at 12:05:27PM +0200, Adriana Reus wrote:
> +MODULE_DEVICE_TABLE(acpi, inv_acpi_match);
> +
> +static struct i2c_driver inv_mpu_driver = {
> + .probe = inv_mpu_probe,
> + .remove = inv_mpu_remove,
> + .id_table = inv_mpu_id,
> + .driver = {
> + .acpi_match_table = ACPI_PTR(inv_acpi_match),
> + .name = "inv-mpu6050 i2c driver",
I just noticed this but spaces in this name leads to spaces in the sysfs entry
which could be potentially confusing.
root@dragonboard-410c:/sys/bus/i2c/drivers# ls
ads1015 cs2000-cp inv-mpu6050 i2c driver
ak4613-codec dummy pca9685-pwm
root@dragonboard-410c:/sys/bus/i2c/drivers# ls -l
drwxr-xr-x 2 root root 0 Feb 5 05:37 ads1015
drwxr-xr-x 2 root root 0 Feb 5 05:37 ak4613-codec
drwxr-xr-x 2 root root 0 Feb 5 05:37 cs2000-cp
drwxr-xr-x 2 root root 0 Feb 5 05:37 dummy
drwxr-xr-x 2 root root 0 Feb 5 05:37 inv-mpu6050 i2c driver
drwxr-xr-x 2 root root 0 Feb 5 05:37 pca9685-pwm
Same goes for the SPI driver.
root@dragonboard-410c:/sys/bus/spi/drivers# ls
inv-mpu6000 spi driver mmc_spi spidev
root@dragonboard-410c:/sys/bus/spi/drivers# ls -l
drwxr-xr-x 2 root root 0 Feb 5 05:43 inv-mpu6000 spi driver
drwxr-xr-x 2 root root 0 Feb 5 05:43 mmc_spi
drwxr-xr-x 2 root root 0 Feb 5 05:43 spidev
Not sure if it is worth a revision but letting you know.
next prev parent reply other threads:[~2016-02-11 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 10:05 [PATCH v5 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Adriana Reus
2016-02-11 10:05 ` [PATCH v5 1/4] iio: imu: inv-mpu6050: Fix interrupt pin configuration Adriana Reus
2016-02-11 10:05 ` [PATCH v5 2/4] iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions Adriana Reus
2016-02-11 10:05 ` [PATCH v5 3/4] iio: imu: inv_mpu6050: Separate driver into core and i2c functionality Adriana Reus
2016-02-11 18:00 ` Michael Welling [this message]
2016-02-11 10:05 ` [PATCH v5 4/4] iio: imu: inv_mpu6050: Add SPI support for MPU6000 Adriana Reus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211180019.GA15330@deathstar \
--to=mwelling@ieee.org \
--cc=adi.reus@gmail.com \
--cc=adriana.reus@intel.com \
--cc=cmo@melexis.com \
--cc=daniel.baluta@intel.com \
--cc=ggao@invensense.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).