From: Michael Welling <mwelling@ieee.org>
To: Sricharan <sricharan@codeaurora.org>
Cc: 'Daniel Baluta' <daniel.baluta@intel.com>,
'Wolfram Sang' <wsa@the-dreams.de>,
'Jonathan Cameron' <jic23@kernel.org>,
'Hartmut Knaack' <knaack.h@gmx.de>,
'Lars-Peter Clausen' <lars@metafoo.de>,
'Peter Meerwald-Stadler' <pmeerw@pmeerw.net>,
'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org,
'Lucas De Marchi' <lucas.demarchi@intel.com>,
'Andy Gross' <agross@codeaurora.org>,
'Pramod Gurav' <pramod.gurav@smartplayin.com>,
'Bjorn Andersson' <bjorn.andersson@sonymobile.com>,
'Guenter Roeck' <linux@roeck-us.net>,
eibach@gdsys.de, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
Date: Wed, 17 Feb 2016 17:53:14 -0600 [thread overview]
Message-ID: <20160217235314.GA13145@deathstar> (raw)
In-Reply-To: <20160210163622.GA1390@deathstar>
On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote:
> On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote:
> > > Hi Sricharan,
> > >
> > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c
> > > right?
> > >
> > Yes.
> >
> > > I'm asking this because this driver doesn't seem to support runtime pm and
> > > there is no check for regmap_write/regmap_write return code in the probe
> > > function.
> > Hmm to be clear, so it’s the pm_runtime_getsync from i2c-qup which fails right ?
> > I was tracking that when there are i2c_xfers from pwm. I did not see any failures there.
> > So wanted to know the correct sequence to reproduce.
> >
>
> The problem was discovered using the patch that this thread is on. The PWM driver does
> not have the problem.
>
> When the driver in this patch called pm_runtime_get_sync you got -EINVAL back.
I noticed some patches for the QUP I2C driver in linux-next so I built against it.
The ADC driver now appears to work as desired.
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage0_raw
287
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage1_raw
269
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage2_raw
270
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage3_raw
271
>
> > Regards,
> > Sricharan
> >
> >
> >
next prev parent reply other threads:[~2016-02-17 23:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 13:17 [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta
2016-02-05 17:25 ` Michael Welling
2016-02-05 19:32 ` Daniel Baluta
2016-02-05 19:50 ` Michael Welling
2016-02-06 0:32 ` Michael Welling
2016-02-08 10:25 ` Wolfram Sang
2016-02-08 14:44 ` Daniel Baluta
2016-02-08 15:03 ` Daniel Baluta
2016-02-08 16:37 ` Michael Welling
2016-02-08 16:36 ` Michael Welling
2016-02-08 19:11 ` Sricharan
2016-02-08 19:16 ` Michael Welling
2016-02-08 20:00 ` Wolfram Sang
2016-02-08 20:06 ` Michael Welling
2016-02-10 12:22 ` Sricharan
2016-02-10 12:56 ` Daniel Baluta
2016-02-10 15:09 ` Sricharan
2016-02-10 16:36 ` Michael Welling
2016-02-17 23:53 ` Michael Welling [this message]
2016-02-18 8:45 ` Sricharan
2016-02-05 21:02 ` Lucas De Marchi
2016-02-05 21:44 ` Daniel Baluta
2016-02-06 10:52 ` Jonathan Cameron
2016-02-06 11:05 ` Jonathan Cameron
2016-02-06 11:07 ` Jonathan Cameron
2016-03-01 0:50 ` Michael Welling
2016-03-01 1:09 ` Lucas De Marchi
2016-03-01 1:16 ` Michael Welling
2016-03-01 1:33 ` Michael Welling
2016-03-01 2:42 ` Michael Welling
2016-03-01 8:35 ` jic23
2016-03-01 16:02 ` Michael Welling
2016-03-01 17:24 ` Jonathan Cameron
2016-03-01 11:28 ` Daniel Baluta
2016-03-01 15:57 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217235314.GA13145@deathstar \
--to=mwelling@ieee.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=daniel.baluta@intel.com \
--cc=eibach@gdsys.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lucas.demarchi@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=pramod.gurav@smartplayin.com \
--cc=sricharan@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).