From: Vlad Dogaru <vlad.dogaru@intel.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-iio@vger.kernel.org,
Christoph Mair <christoph.mair@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: pressure: bmp280: add support for BMP180
Date: Mon, 11 Apr 2016 11:44:59 +0300 [thread overview]
Message-ID: <20160411084459.GA31705@vdogaru> (raw)
In-Reply-To: <CAC5umyjDk_LE-g+yJ5Lin+OPE2T5-3_V5VO_tO+F5TGaPp=tvg@mail.gmail.com>
On Sat, Apr 09, 2016 at 03:53:39AM +0900, Akinobu Mita wrote:
> 2016-04-08 19:43 GMT+09:00 Vlad Dogaru <vlad.dogaru@intel.com>:
> > On Fri, Apr 08, 2016 at 12:57:01AM +0900, Akinobu Mita wrote:
> [...]
> >> +static int bmp180_chip_init(struct bmp280_data *data)
> >> +{
> >> + return 0;
> >> +}
> >
> > When setting the oversampling ratio, we do a lookup in the available
> > values array, then call ops->init to write the values to the register.
> > This function does nothing in the bmp180 case. Or am I missing
> > something?
>
> Your understanding is correct. There is nothing to do for bmp180 when
> the oversampling setting is changed by the user. When the actual
> measurement is requested, the measurement conversion is started by
> writing ctrl_meas register with the oversampling setting and start
> conversion bit.
Ah, I see. That makes sense, thanks for the explanation.
Vlad
next prev parent reply other threads:[~2016-04-11 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:57 [PATCH] iio: pressure: bmp280: add support for BMP180 Akinobu Mita
2016-04-08 10:43 ` Vlad Dogaru
2016-04-08 18:53 ` Akinobu Mita
2016-04-11 8:44 ` Vlad Dogaru [this message]
2016-04-10 11:32 ` Jonathan Cameron
2016-04-11 0:33 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411084459.GA31705@vdogaru \
--to=vlad.dogaru@intel.com \
--cc=akinobu.mita@gmail.com \
--cc=christoph.mair@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox