[PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[Alison Schofield]

hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
humidity and temperature sensors. Add these product names to
Kconfig and to the drivers device id structure to enable finding
the product by name and using it to add a device.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 drivers/iio/humidity/Kconfig   | 8 ++++----
 drivers/iio/humidity/hdc100x.c | 2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
index 738a86d..f155386 100644
--- a/drivers/iio/humidity/Kconfig
+++ b/drivers/iio/humidity/Kconfig
@@ -26,11 +26,11 @@ config HDC100X
 	tristate "TI HDC100x relative humidity and temperature sensor"
 	depends on I2C
 	help
-	 Say yes here to build support for the TI HDC100x series of
-	 relative humidity and temperature sensors.
+	  Say yes here to build support for the Texas Instruments
+	  HDC1000 and HDC1008 relative humidity and temperature sensors.
 
-	 To compile this driver as a module, choose M here: the module
-	 will be called hdc100x.
+	  To compile this driver as a module, choose M here: the module
+	  will be called hdc100x.
 
 config HTU21
 	tristate "Measurement Specialties HTU21 humidity & temperature sensor"
diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index fa47676..0deb874 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
 
 static const struct i2c_device_id hdc100x_id[] = {
 	{ "hdc100x", 0 },
+	{ "hdc1000", 0 },
+	{ "hdc1008", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, hdc100x_id);
-- 
2.1.4

Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[Matt Ranostay]

On Fri, May 20, 2016 at 10:05 AM, Alison Schofield <amsfield22@gmail.com> wrote:
> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
> humidity and temperature sensors. Add these product names to
> Kconfig and to the drivers device id structure to enable finding
> the product by name and using it to add a device.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
>  drivers/iio/humidity/Kconfig   | 8 ++++----
>  drivers/iio/humidity/hdc100x.c | 2 ++
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index 738a86d..f155386 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -26,11 +26,11 @@ config HDC100X
>         tristate "TI HDC100x relative humidity and temperature sensor"
>         depends on I2C
>         help
> -        Say yes here to build support for the TI HDC100x series of
> -        relative humidity and temperature sensors.
> +         Say yes here to build support for the Texas Instruments
> +         HDC1000 and HDC1008 relative humidity and temperature sensors.
>
> -        To compile this driver as a module, choose M here: the module
> -        will be called hdc100x.
> +         To compile this driver as a module, choose M here: the module
> +         will be called hdc100x.
>
>  config HTU21
>         tristate "Measurement Specialties HTU21 humidity & temperature sensor"
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index fa47676..0deb874 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
>
>  static const struct i2c_device_id hdc100x_id[] = {
>         { "hdc100x", 0 },
> +       { "hdc1000", 0 },
> +       { "hdc1008", 0 },

Personally I think adding more device ids that don't add any per chip
configuration is just adding clutter.
There is a reason I used "hdc100x" when I wrote the driver :)


>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
> --
> 2.1.4
>

Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[Jonathan Cameron]

On 20/05/16 18:34, Matt Ranostay wrote:
> On Fri, May 20, 2016 at 10:05 AM, Alison Schofield <amsfield22@gmail.com> wrote:
>> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
>> humidity and temperature sensors. Add these product names to
>> Kconfig and to the drivers device id structure to enable finding
>> the product by name and using it to add a device.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>> ---
>>  drivers/iio/humidity/Kconfig   | 8 ++++----
>>  drivers/iio/humidity/hdc100x.c | 2 ++
>>  2 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>> index 738a86d..f155386 100644
>> --- a/drivers/iio/humidity/Kconfig
>> +++ b/drivers/iio/humidity/Kconfig
>> @@ -26,11 +26,11 @@ config HDC100X
>>         tristate "TI HDC100x relative humidity and temperature sensor"
>>         depends on I2C
>>         help
>> -        Say yes here to build support for the TI HDC100x series of
>> -        relative humidity and temperature sensors.
>> +         Say yes here to build support for the Texas Instruments
>> +         HDC1000 and HDC1008 relative humidity and temperature sensors.
>>
>> -        To compile this driver as a module, choose M here: the module
>> -        will be called hdc100x.
>> +         To compile this driver as a module, choose M here: the module
>> +         will be called hdc100x.
>>
>>  config HTU21
>>         tristate "Measurement Specialties HTU21 humidity & temperature sensor"
>> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
>> index fa47676..0deb874 100644
>> --- a/drivers/iio/humidity/hdc100x.c
>> +++ b/drivers/iio/humidity/hdc100x.c
>> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
>>
>>  static const struct i2c_device_id hdc100x_id[] = {
>>         { "hdc100x", 0 },
>> +       { "hdc1000", 0 },
>> +       { "hdc1008", 0 },
> 
> Personally I think adding more device ids that don't add any per chip
> configuration is just adding clutter.
> There is a reason I used "hdc100x" when I wrote the driver :)
Hmm. I should have picked up on this in the first place. It's much preferred to
go with complete part names.  Avoids any possible issues with devicetrees / ACPI
bindings where it's kind of assumed a whole part name will be used.

I'd prefer to have them explicitly listed.  We will have to keep the wild card
form as well as by now there will be boards using that out there.
If it was just internal to the kernel I'd agree with the clutter argument, but
it isn't so let us be as explicit in the naming as possible.

Jonathan
> 
> 
>>         { }
>>  };
>>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
>> --
>> 2.1.4
>>

Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[Alison Schofield]

On Sat, May 21, 2016 at 05:27:16PM +0100, Jonathan Cameron wrote:
> On 20/05/16 18:34, Matt Ranostay wrote:
> > On Fri, May 20, 2016 at 10:05 AM, Alison Schofield <amsfield22@gmail.com> wrote:
> >> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
> >> humidity and temperature sensors. Add these product names to
> >> Kconfig and to the drivers device id structure to enable finding
> >> the product by name and using it to add a device.
> >>
> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> >> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> >> ---
> >>  drivers/iio/humidity/Kconfig   | 8 ++++----
> >>  drivers/iio/humidity/hdc100x.c | 2 ++
> >>  2 files changed, 6 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> >> index 738a86d..f155386 100644
> >> --- a/drivers/iio/humidity/Kconfig
> >> +++ b/drivers/iio/humidity/Kconfig
> >> @@ -26,11 +26,11 @@ config HDC100X
> >>         tristate "TI HDC100x relative humidity and temperature sensor"
> >>         depends on I2C
> >>         help
> >> -        Say yes here to build support for the TI HDC100x series of
> >> -        relative humidity and temperature sensors.
> >> +         Say yes here to build support for the Texas Instruments
> >> +         HDC1000 and HDC1008 relative humidity and temperature sensors.
> >>
> >> -        To compile this driver as a module, choose M here: the module
> >> -        will be called hdc100x.
> >> +         To compile this driver as a module, choose M here: the module
> >> +         will be called hdc100x.
> >>
> >>  config HTU21
> >>         tristate "Measurement Specialties HTU21 humidity & temperature sensor"
> >> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> >> index fa47676..0deb874 100644
> >> --- a/drivers/iio/humidity/hdc100x.c
> >> +++ b/drivers/iio/humidity/hdc100x.c
> >> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
> >>
> >>  static const struct i2c_device_id hdc100x_id[] = {
> >>         { "hdc100x", 0 },
> >> +       { "hdc1000", 0 },
> >> +       { "hdc1008", 0 },
> > 
> > Personally I think adding more device ids that don't add any per chip
> > configuration is just adding clutter.
> > There is a reason I used "hdc100x" when I wrote the driver :)
> Hmm. I should have picked up on this in the first place. It's much preferred to
> go with complete part names.  Avoids any possible issues with devicetrees / ACPI
> bindings where it's kind of assumed a whole part name will be used.
> 
> I'd prefer to have them explicitly listed.  We will have to keep the wild card
> form as well as by now there will be boards using that out there.
> If it was just internal to the kernel I'd agree with the clutter argument, but
> it isn't so let us be as explicit in the naming as possible.
> 
> Jonathan

Jonathan,

It seemed like you were going to take this patch, but haven't.
I can pull the names out of the device_id fields if wanted, but it would
be nice to at least have them in the Kconfig so one can grep for these names.
Let me know if it needs a v2.

Thanks,
alisons

> > 
> > 
> >>         { }
> >>  };
> >>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
> >> --
> >> 2.1.4
> >>
> 

Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

[Jonathan Cameron]

On 18/07/16 20:43, Alison Schofield wrote:
> On Sat, May 21, 2016 at 05:27:16PM +0100, Jonathan Cameron wrote:
>> On 20/05/16 18:34, Matt Ranostay wrote:
>>> On Fri, May 20, 2016 at 10:05 AM, Alison Schofield <amsfield22@gmail.com> wrote:
>>>> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
>>>> humidity and temperature sensors. Add these product names to
>>>> Kconfig and to the drivers device id structure to enable finding
>>>> the product by name and using it to add a device.
>>>>
>>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>>>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>>> ---
>>>>  drivers/iio/humidity/Kconfig   | 8 ++++----
>>>>  drivers/iio/humidity/hdc100x.c | 2 ++
>>>>  2 files changed, 6 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>>>> index 738a86d..f155386 100644
>>>> --- a/drivers/iio/humidity/Kconfig
>>>> +++ b/drivers/iio/humidity/Kconfig
>>>> @@ -26,11 +26,11 @@ config HDC100X
>>>>         tristate "TI HDC100x relative humidity and temperature sensor"
>>>>         depends on I2C
>>>>         help
>>>> -        Say yes here to build support for the TI HDC100x series of
>>>> -        relative humidity and temperature sensors.
>>>> +         Say yes here to build support for the Texas Instruments
>>>> +         HDC1000 and HDC1008 relative humidity and temperature sensors.
>>>>
>>>> -        To compile this driver as a module, choose M here: the module
>>>> -        will be called hdc100x.
>>>> +         To compile this driver as a module, choose M here: the module
>>>> +         will be called hdc100x.
>>>>
>>>>  config HTU21
>>>>         tristate "Measurement Specialties HTU21 humidity & temperature sensor"
>>>> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
>>>> index fa47676..0deb874 100644
>>>> --- a/drivers/iio/humidity/hdc100x.c
>>>> +++ b/drivers/iio/humidity/hdc100x.c
>>>> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
>>>>
>>>>  static const struct i2c_device_id hdc100x_id[] = {
>>>>         { "hdc100x", 0 },
>>>> +       { "hdc1000", 0 },
>>>> +       { "hdc1008", 0 },
>>>
>>> Personally I think adding more device ids that don't add any per chip
>>> configuration is just adding clutter.
>>> There is a reason I used "hdc100x" when I wrote the driver :)
>> Hmm. I should have picked up on this in the first place. It's much preferred to
>> go with complete part names.  Avoids any possible issues with devicetrees / ACPI
>> bindings where it's kind of assumed a whole part name will be used.
>>
>> I'd prefer to have them explicitly listed.  We will have to keep the wild card
>> form as well as by now there will be boards using that out there.
>> If it was just internal to the kernel I'd agree with the clutter argument, but
>> it isn't so let us be as explicit in the naming as possible.
>>
>> Jonathan
> 
> Jonathan,
> 
> It seemed like you were going to take this patch, but haven't.
> I can pull the names out of the device_id fields if wanted, but it would
> be nice to at least have them in the Kconfig so one can grep for these names.
> Let me know if it needs a v2.
> 
yes please.
> Thanks,
> alisons
> 
>>>
>>>
>>>>         { }
>>>>  };
>>>>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
>>>> --
>>>> 2.1.4
>>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>