From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
wens@csie.org, lee.jones@linaro.org,
thomas.petazzoni@free-electrons.com,
antoine.tenart@free-electrons.com, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC
Date: Mon, 5 Sep 2016 09:07:16 +0200 [thread overview]
Message-ID: <20160905070716.GA6322@lukather> (raw)
In-Reply-To: <1472738705-20145-4-git-send-email-quentin.schulz@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
Hi,
Nitpicks ahead.
On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote:
> + info->soc_specific = (struct soc_specific *)platform_get_device_id(pdev)->driver_data;
This line is still rather long. How about calling the field "data" and
the structure gpadc_data?
> +
> + tzd = devm_thermal_zone_of_sensor_register(pdev->dev.parent, 0, info,
> + &sun4i_ts_tz_ops);
A comment on why you put the parent device structure and not the
device itself like you're doing on all the other calls in that probe
would be nice.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-05 7:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 14:05 [PATCH v4 0/3] add support for Allwinner SoCs ADC Quentin Schulz
2016-09-01 14:05 ` [PATCH v4 1/3] hwmon: iio_hwmon: delay probing with late_initcall Quentin Schulz
2016-09-01 14:05 ` [PATCH v4 2/3] mfd: add support for Allwinner SoCs ADC Quentin Schulz
2016-09-04 14:36 ` Jonathan Cameron
2016-09-01 14:05 ` [PATCH v4 3/3] iio: adc: " Quentin Schulz
2016-09-04 14:35 ` Jonathan Cameron
2016-09-05 6:29 ` Quentin Schulz
2016-09-05 19:51 ` Jonathan Cameron
2016-09-04 16:12 ` Peter Meerwald-Stadler
2016-09-05 6:48 ` Quentin Schulz
2016-09-05 8:07 ` Peter Meerwald-Stadler
2016-09-05 8:52 ` Quentin Schulz
2016-09-05 9:02 ` Peter Meerwald-Stadler
2016-09-05 7:07 ` Maxime Ripard [this message]
2016-09-05 7:11 ` Quentin Schulz
2016-09-05 16:47 ` Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905070716.GA6322@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).