* [PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address
@ 2016-09-20 9:38 Brian Masney
2016-09-20 9:38 ` [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments Brian Masney
0 siblings, 1 reply; 3+ messages in thread
From: Brian Masney @ 2016-09-20 9:38 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, devel
Address warning from checkpatch:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
drivers/staging/iio/light/isl29018.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 76d9f74..ea4d7f1 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -15,10 +15,6 @@
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
#include <linux/module.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments
2016-09-20 9:38 [PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address Brian Masney
@ 2016-09-20 9:38 ` Brian Masney
2016-09-20 10:08 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Brian Masney @ 2016-09-20 9:38 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, devel
Address warning from checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
drivers/staging/iio/light/isl29018.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index ea4d7f1..4401451 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
return status;
}
- status = isl29018_set_integration_time(chip,
- isl29018_int_utimes[chip->type][chip->int_time]);
+ status = isl29018_set_integration_time(
+ chip, isl29018_int_utimes[chip->type][chip->int_time]);
if (status < 0) {
dev_err(dev, "Init of isl29018 fails\n");
return status;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments
2016-09-20 9:38 ` [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments Brian Masney
@ 2016-09-20 10:08 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-09-20 10:08 UTC (permalink / raw)
To: Brian Masney; +Cc: gregkh, linux-iio, devel
On Tue, Sep 20, 2016 at 05:38:57AM -0400, Brian Masney wrote:
> Address warning from checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> drivers/staging/iio/light/isl29018.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index ea4d7f1..4401451 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
> return status;
> }
>
> - status = isl29018_set_integration_time(chip,
> - isl29018_int_utimes[chip->type][chip->int_time]);
> + status = isl29018_set_integration_time(
> + chip, isl29018_int_utimes[chip->type][chip->int_time]);
Congrats on finding a hack to silence checkpatch but this doesn't really
improve the code at all... It's ok to ignore checkpatch.pl.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-20 10:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-20 9:38 [PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address Brian Masney
2016-09-20 9:38 ` [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments Brian Masney
2016-09-20 10:08 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).