[PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Ico Doornekamp]

Signed-off-by: Ico Doornekamp <ico@pruts.nl>
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
index b5625f5..61f3241 100644
--- a/drivers/staging/iio/accel/sca3000_core.c
+++ b/drivers/staging/iio/accel/sca3000_core.c
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),
-- 
2.9.3

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Jonathan Cameron]

On 09/09/16 18:44, Ico Doornekamp wrote:
> Signed-off-by: Ico Doornekamp <ico@pruts.nl>
Hi

Clifton Barnes sent a patch for this a few weeks ago and
I have already applied that patch.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/accel/sca3000_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> index b5625f5..61f3241 100644
> --- a/drivers/staging/iio/accel/sca3000_core.c
> +++ b/drivers/staging/iio/accel/sca3000_core.c
> @@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
>  		},						\
>  		.event_spec = &sca3000_event,			\
>  		.num_event_specs = 1,				\
> -	 }
> +	}
>  
>  static const struct iio_chan_spec sca3000_channels[] = {
>  	SCA3000_CHAN(0, IIO_MOD_X),
> 

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Ico Doornekamp]

* On 2016-09-10 16:57:18 +0200, Jonathan Cameron wrote:
 
> Clifton Barnes sent a patch for this a few weeks ago and
> I have already applied that patch.

Oh, so I'm probably working from the wrong tree, linux-next seems to be
behind on this; does linux-iio have its own git tree somewhere?

(I'm sorry if I'm generating noise on the list here. As is probably
obvious, I'm here because of the The Eudyptula Challenge [1]; the
current task being to fix a style violation somewhere in the staging
tree. Since IIO is the single part of the staging tree I actually use in
real life, I though this might be the right place for me to come to.
Too bad for me that there's not much style issues in the IIO tree
though)

1. http://eudyptula-challenge.org/

-- 
:wq
^X^Cy^K^X^C^C^C^C

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Jonathan Cameron]

On 10/09/16 17:01, Ico Doornekamp wrote:
> * On 2016-09-10 16:57:18 +0200, Jonathan Cameron wrote:
>  
>> Clifton Barnes sent a patch for this a few weeks ago and
>> I have already applied that patch.
> 
> Oh, so I'm probably working from the wrong tree, linux-next seems to be
> behind on this; does linux-iio have its own git tree somewhere?
Yes
https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/

Most recent branch if normally 'testing' which is there for the
various automated build tests to report on.

Path to linux next is that I have to send Greg KH a pull request
(will be doing one tomorrow probably) and then he pulls it into
staging-next which is pulled into linux-next.
> 
> (I'm sorry if I'm generating noise on the list here. As is probably
> obvious, I'm here because of the The Eudyptula Challenge [1]; the
> current task being to fix a style violation somewhere in the staging
> tree. Since IIO is the single part of the staging tree I actually use in
> real life, I though this might be the right place for me to come to.
Cool
> Too bad for me that there's not much style issues in the IIO tree
> though)
Largely because others have been here before you and picked off the
low hanging fruit.  All our remaining staging drivers have been there
a 'long' time!
> 
> 1. http://eudyptula-challenge.org/
Don't worry about it!   We are always happy to help out people who
are just getting started.

If you want to try something a little more 'meaty' take a staging
driver and play spot the ABI that is either 'wrong' or not yet
documented under

Documentation/ABI/testing/sysfs-bus-iio*

If it's obviously not covered by the ABI docs then post a documentation
patch.  This often kicks off a discussion on what the interface
'should' be ;)

Another good one is to find things in staging drivers that we now
have IIO_INFO_* elements for.

For example in sca3000 I see there is an explicit attribute defined that
could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
relevant masks and appropriate sections added to the read_raw
and write_raw callbacks.

Not a trivial job, but not too hard to figure out perhaps?

+ a good step up from white space patches.

Guess maybe that needs to be a bit later if you are ploughing through
the eudyptula-challenge (though that didn't exist when I got started
so I don't know what order they do stuff in!)

Jonathan

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Ico Doornekamp]

* On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
 
> Another good one is to find things in staging drivers that we now
> have IIO_INFO_* elements for.
> 
> For example in sca3000 I see there is an explicit attribute defined that
> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
> relevant masks and appropriate sections added to the read_raw
> and write_raw callbacks.
>
> Not a trivial job, but not too hard to figure out perhaps?

Not too hard, although I'm not able to actually run and test due to lack
of hardware.

> + a good step up from white space patches.

I do hope the Little Penguin agrees on this :)

> Guess maybe that needs to be a bit later if you are ploughing through
> the eudyptula-challenge (though that didn't exist when I got started
> so I don't know what order they do stuff in!)

I have no clue: I'm trying to stick to the steps and not peek ahead.

-- 
:wq
^X^Cy^K^X^C^C^C^C

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Jonathan Cameron]

On 10/09/16 19:16, Ico Doornekamp wrote:
> * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
>  
>> Another good one is to find things in staging drivers that we now
>> have IIO_INFO_* elements for.
>>
>> For example in sca3000 I see there is an explicit attribute defined that
>> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
>> relevant masks and appropriate sections added to the read_raw
>> and write_raw callbacks.
>>
>> Not a trivial job, but not too hard to figure out perhaps?
> 
> Not too hard, although I'm not able to actually run and test due to lack
> of hardware.
That's fine. This one is my driver (rather needing some care and attention)
and I have the hardware still.  It's somewhat of a pain to fire up so
I might do this one just on review but we'll see how busy I am at the weekend.
> 
>> + a good step up from white space patches.
> 
> I do hope the Little Penguin agrees on this :)
Should do!
> 
>> Guess maybe that needs to be a bit later if you are ploughing through
>> the eudyptula-challenge (though that didn't exist when I got started
>> so I don't know what order they do stuff in!)
> 
> I have no clue: I'm trying to stick to the steps and not peek ahead.
> 

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Alison Schofield]

On Tue, Sep 13, 2016 at 06:37:17PM +0100, Jonathan Cameron wrote:
> On 10/09/16 19:16, Ico Doornekamp wrote:
> > * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
> >  
> >> Another good one is to find things in staging drivers that we now
> >> have IIO_INFO_* elements for.
> >>
> >> For example in sca3000 I see there is an explicit attribute defined that
> >> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
> >> relevant masks and appropriate sections added to the read_raw
> >> and write_raw callbacks.
> >>
> >> Not a trivial job, but not too hard to figure out perhaps?

Not trying to hijack Ico's work ;) but wondering if this task, applied to
staging drivers, would be good to offer to this round of Outreachy
applicants as a small coding task?

alisons

> > 
> > Not too hard, although I'm not able to actually run and test due to lack
> > of hardware.
> That's fine. This one is my driver (rather needing some care and attention)
> and I have the hardware still.  It's somewhat of a pain to fire up so
> I might do this one just on review but we'll see how busy I am at the weekend.
> > 
> >> + a good step up from white space patches.
> > 
> > I do hope the Little Penguin agrees on this :)
> Should do!
> > 
> >> Guess maybe that needs to be a bit later if you are ploughing through
> >> the eudyptula-challenge (though that didn't exist when I got started
> >> so I don't know what order they do stuff in!)
> > 
> > I have no clue: I'm trying to stick to the steps and not peek ahead.
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Jonathan Cameron]

On 13/09/16 20:22, Alison Schofield wrote:
> On Tue, Sep 13, 2016 at 06:37:17PM +0100, Jonathan Cameron wrote:
>> On 10/09/16 19:16, Ico Doornekamp wrote:
>>> * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
>>>  
>>>> Another good one is to find things in staging drivers that we now
>>>> have IIO_INFO_* elements for.
>>>>
>>>> For example in sca3000 I see there is an explicit attribute defined that
>>>> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
>>>> relevant masks and appropriate sections added to the read_raw
>>>> and write_raw callbacks.
>>>>
>>>> Not a trivial job, but not too hard to figure out perhaps?
> 
> Not trying to hijack Ico's work ;) but wondering if this task, applied to
> staging drivers, would be good to offer to this round of Outreachy
> applicants as a small coding task?
There are probably other cases still out there.  Wouldn't guarantee they
are all in staging either!

Commenting out the relevant macros in include/linux/iio/sysfs.h is
a good way to find these.  The whole shared_by_... stuff is
'relatively recent' so quite a few drivers predate it.

Good to get them cleaned up and it's not a bad step up from
white space fixes (as Ico has just demonstrated ;)

Thanks,

Jonathan

> 
> alisons
> 
>>>
>>> Not too hard, although I'm not able to actually run and test due to lack
>>> of hardware.
>> That's fine. This one is my driver (rather needing some care and attention)
>> and I have the hardware still.  It's somewhat of a pain to fire up so
>> I might do this one just on review but we'll see how busy I am at the weekend.
>>>
>>>> + a good step up from white space patches.
>>>
>>> I do hope the Little Penguin agrees on this :)
>> Should do!
>>>
>>>> Guess maybe that needs to be a bit later if you are ploughing through
>>>> the eudyptula-challenge (though that didn't exist when I got started
>>>> so I don't know what order they do stuff in!)
>>>
>>> I have no clue: I'm trying to stick to the steps and not peek ahead.
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space

[Alison Schofield]

On Sun, Sep 18, 2016 at 11:53:09AM +0100, Jonathan Cameron wrote:
> On 13/09/16 20:22, Alison Schofield wrote:
> > On Tue, Sep 13, 2016 at 06:37:17PM +0100, Jonathan Cameron wrote:
> >> On 10/09/16 19:16, Ico Doornekamp wrote:
> >>> * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
> >>>  
> >>>> Another good one is to find things in staging drivers that we now
> >>>> have IIO_INFO_* elements for.
> >>>>
> >>>> For example in sca3000 I see there is an explicit attribute defined that
> >>>> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
> >>>> relevant masks and appropriate sections added to the read_raw
> >>>> and write_raw callbacks.
> >>>>
> >>>> Not a trivial job, but not too hard to figure out perhaps?
> > 
> > Not trying to hijack Ico's work ;) but wondering if this task, applied to
> > staging drivers, would be good to offer to this round of Outreachy
> > applicants as a small coding task?
> There are probably other cases still out there.  Wouldn't guarantee they
> are all in staging either!
> 
> Commenting out the relevant macros in include/linux/iio/sysfs.h is
> a good way to find these.  The whole shared_by_... stuff is
> 'relatively recent' so quite a few drivers predate it.
> 
> Good to get them cleaned up and it's not a bad step up from
> white space fixes (as Ico has just demonstrated ;)
> 
> Thanks,
> 
> Jonathan
> 

OK, it's out there as a task for Outreachy applicants.
Hopefully you'll see some incoming shortly.
(https://kernelnewbies.org/IIO_tasks)
alisons


> > 
> > alisons
> > 
> >>>
> >>> Not too hard, although I'm not able to actually run and test due to lack
> >>> of hardware.
> >> That's fine. This one is my driver (rather needing some care and attention)
> >> and I have the hardware still.  It's somewhat of a pain to fire up so
> >> I might do this one just on review but we'll see how busy I am at the weekend.
> >>>
> >>>> + a good step up from white space patches.
> >>>
> >>> I do hope the Little Penguin agrees on this :)
> >> Should do!
> >>>
> >>>> Guess maybe that needs to be a bit later if you are ploughing through
> >>>> the eudyptula-challenge (though that didn't exist when I got started
> >>>> so I don't know what order they do stuff in!)
> >>>
> >>> I have no clue: I'm trying to stick to the steps and not peek ahead.
> >>>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
>