From: Brian Masney <masneyb@onstation.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 5/5] staging: iio: isl29018: check if the chip is in a suspended state
Date: Sat, 1 Oct 2016 11:30:31 -0400 [thread overview]
Message-ID: <20161001153031.GA16708@basecamp.onstation.org> (raw)
In-Reply-To: <547487cf-87f7-0922-ad30-cf8dff599d71@kernel.org>
On Sat, Oct 01, 2016 at 02:59:49PM +0100, Jonathan Cameron wrote:
> On 27/09/16 01:20, Brian Masney wrote:
> > Add a check to isl29018_write_raw() to ensure that the chip is not in a
> > suspended state. This makes the code consistent with what is present
> > in isl29018_read_raw().
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> Applied to the togreg branch of iio.git.
>
> Out of curiosity, do you actually have one of these?
>
> At a quick glance, the only remaining bit keeping this driver
> in staging is the lack of docs on the infrared_supression
> attribute. If you want to add something on that and a patch
> moving it out of staging that would be great.
>
> However, note that the graduation patch is usually the one
> that gets the driver thoroughly reviewed by several people so
> more stuff may come out of the woodwork.
I do not have a device with this hardware. I picked a random driver in
the IIO subsystem to cleanup with the goal of getting it closer towards
graduation from staging. I'm planning to move on to another driver in
IIO once I can't get any further without having the hardware on
hand.
I see two other issues that need to be addressed with that driver:
- in_illuminance_scale_available_show() and
in_illuminance_integration_time_available_show() each return four
different values in their sysfs attribute. My understanding is that
only a single value should be in the sysfs attribute. If that is the
case, then should the attributes be something like:
in_illuminance_scale_available_16
in_illuminance_scale_available_12
in_illuminance_scale_available_8
in_illuminance_scale_available_4
in_illuminance_integration_time_available_16
...
I got the numbers from the isl29018_int_time enum. If this is
acceptable, then I'll submit some patches with these changes.
- checkpatch - need to add device tree documentation
I'll also investigate adding the infrared supression documentation
although I'm not sure how far I'll get on that without having the
hardware available.
Brian
next prev parent reply other threads:[~2016-10-01 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 17:29 [PATCH 1/2] include: linux: iio: add IIO_DEVICE_ATTR_{RO,WO,RW} macros Brian Masney
2016-09-25 17:29 ` [PATCH 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO,RW} macros Brian Masney
2016-09-25 17:58 ` [PATCH 1/2] include: linux: iio: add IIO_DEVICE_ATTR_{RO, WO, RW} macros Greg KH
2016-09-25 19:27 ` [PATCH v2 1/2] include: linux: iio: add IIO_ATTR_{RO,WO,RW} and IIO_DEVICE_ATTR_{RO,WO,RW} macros Brian Masney
2016-09-26 7:59 ` [PATCH v2 1/2] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros Greg KH
2016-09-27 0:20 ` [PATCH v3 1/5] " Brian Masney
2016-09-27 0:20 ` [PATCH v3 2/5] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, " Brian Masney
2016-10-01 13:48 ` Jonathan Cameron
2016-09-27 0:20 ` [PATCH v3 3/5] staging: iio: isl29018: fixed race condition in in_illuminance_scale_available_show() Brian Masney
2016-10-01 13:53 ` Jonathan Cameron
2016-09-27 0:20 ` [PATCH v3 5/5] staging: iio: isl29018: check if the chip is in a suspended state Brian Masney
2016-10-01 13:59 ` Jonathan Cameron
2016-10-01 15:30 ` Brian Masney [this message]
2016-10-01 15:56 ` Jonathan Cameron
2016-10-01 13:47 ` [PATCH v3 1/5] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros Jonathan Cameron
[not found] ` <1474935620-13151-4-git-send-email-masneyb@onstation.org>
2016-10-01 13:55 ` [PATCH v3 4/5] staging: iio: isl29018: change isl29018_read_raw() to only have one exit point Jonathan Cameron
2016-09-25 19:27 ` [PATCH v2 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO,RW} macros Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001153031.GA16708@basecamp.onstation.org \
--to=masneyb@onstation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).