From: Alison Schofield <amsfield22@gmail.com>
To: Ico Doornekamp <ico@pruts.nl>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] io: adc: ad7606_core: fix signed/unsigned number comparison
Date: Sat, 1 Oct 2016 09:49:33 -0700 [thread overview]
Message-ID: <20161001164932.GA2815@d830.WORKGROUP> (raw)
In-Reply-To: <1475338371-sup-5926@pruts.nl>
On Sat, Oct 01, 2016 at 06:17:02PM +0200, Ico Doornekamp wrote:
> * On 2016-10-01 18:09:44 +0200, Jonathan Cameron wrote:
>
> > On 28/09/16 14:41, Ico Doornekamp wrote:
> > > reported by 'make W=2' in ad7606_oversampling_get_index()
> > >
> > > Signed-off-by: Ico Doornekamp <ico@pruts.nl>
> > hmm. It's pretty much a non problem in the first place as we know
> > it can't cause issues (can see it is 7). Also this really just
> > moves to typecasting it later when we return i.
> >
> > So unless I'm missing something I'm not going to apply this one.
>
> Fair enough. It's one of those little penguin task things again, you
> probably guessed already. 'Find a bug reported by sparse and fix it'.
> But your IIO tree is simply too high-quality, sparse has nothing to
> complain :)
Hi Ico,
Flattering the maintainer, always good and so true, so true :)
Here's something found by sparse for little penguin.
See the Outreachy tasks page. https://kernelnewbies.org/IIO_tasks
You'll see I leveraged your IIO_CHAN* patch for the first coding task.
We have a second coding task for sparse endianness patches. There are
some remaining. If you tell me you're grabbing one, I'll put it on
our claimed page so an applicant doesn't start on it.
I know this one is unclaimed at the moment:
CHECK drivers/iio/magnetometer/ak8974.c
drivers/iio/magnetometer/ak8974.c:403:16: warning: cast to restricted
__le16
drivers/iio/magnetometer/ak8974.c:480:24: warning: cast to restricted
__le16
alisons
>
> --
> :wq
> ^X^Cy^K^X^C^C^C^C
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-01 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 13:41 [PATCH] io: adc: ad7606_core: fix signed/unsigned number comparison Ico Doornekamp
2016-10-01 16:09 ` Jonathan Cameron
2016-10-01 16:17 ` Ico Doornekamp
2016-10-01 16:49 ` Alison Schofield [this message]
2016-10-01 17:27 ` Ico Doornekamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001164932.GA2815@d830.WORKGROUP \
--to=amsfield22@gmail.com \
--cc=ico@pruts.nl \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).