From: Eva Rachel Retuya <eraretuya@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com,
knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines
Date: Mon, 31 Oct 2016 15:49:02 +0800 [thread overview]
Message-ID: <20161031074901.GA2207@Socrates-DK> (raw)
In-Reply-To: <5ef0f1e1-236c-0698-cdfc-533125b2d2c7@kernel.org>
On Sun, Oct 30, 2016 at 06:49:00PM +0000, Jonathan Cameron wrote:
> On 30/10/16 17:46, Lars-Peter Clausen wrote:
> > On 10/30/2016 06:41 PM, Jonathan Cameron wrote:
> >> On 28/10/16 09:26, Eva Rachel Retuya wrote:
> >>> Introduce defines for shifting and mask under the config register for
> >>> better readability. Also, introduce helper variables for index
> >>> calculation.
> >>>
> >>> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> >> Looks good to me.
> >>
> >> Lars could you sanity check this one as well?
> >
> > Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> There was a bit of fun applying this. Eva, can you check I didn't mess it
> up?
It looks fine to me. Thanks!
>
> Applied to the togreg branch of iio.git. Initially pushed out as testing
> for the autobuilders to play with it. (and this time I remembered to actually
> do the push!)
>
> thanks,
>
> Jonathan
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
next prev parent reply other threads:[~2016-10-31 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 8:26 [PATCH v3] staging: iio: cdc: ad7746: add additional config defines Eva Rachel Retuya
2016-10-30 17:41 ` Jonathan Cameron
2016-10-30 17:46 ` Lars-Peter Clausen
2016-10-30 18:49 ` Jonathan Cameron
2016-10-31 7:49 ` Eva Rachel Retuya [this message]
2016-10-31 8:05 ` Eva Rachel Retuya
2016-11-01 18:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031074901.GA2207@Socrates-DK \
--to=eraretuya@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).