From: Eva Rachel Retuya <eraretuya@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/2] staging: iio: ad7606: move out of staging
Date: Sat, 12 Nov 2016 22:32:45 +0800 [thread overview]
Message-ID: <20161112143242.GB2214@Socrates-DK> (raw)
In-Reply-To: <280ee49f-7217-6dfc-dcc0-a6c8800144cd@kernel.org>
On Sat, Nov 12, 2016 at 02:26:51PM +0000, Jonathan Cameron wrote:
> On 11/11/16 14:22, Lars-Peter Clausen wrote:
> > On 11/11/2016 07:34 AM, Eva Rachel Retuya wrote:
> >> Move the ad7606 driver from staging/iio/adc to iio/adc. Also, update the
> >> corresponding Makefile and Kconfig associated with the change.
> >
> > This is obviously OK, but when you generate a patch that moves files use
> > `git format-patch -M ...`. This will generate a more compact patch.
> >
> I tend to make an exception for staging graduation patches.
> The mere posting of the whole driver by not using the move detection
> makes for really easy review of whether we have forgotten something
> else that needs cleanup before the graduation.
>
> Most of the time -M is much more sensible!
>
> Jonathan
Should I use this -M on version 2 or still go with the previous method?
Thanks,
Eva
next prev parent reply other threads:[~2016-11-12 14:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 6:34 [PATCH 0/2] staging: iio: ad7606: move driver out of staging Eva Rachel Retuya
2016-11-11 6:34 ` [PATCH 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale Eva Rachel Retuya
2016-11-11 14:18 ` Lars-Peter Clausen
2016-11-12 14:22 ` Eva Rachel Retuya
2016-11-14 10:25 ` Lars-Peter Clausen
2016-11-12 14:24 ` Jonathan Cameron
2016-11-14 10:30 ` Lars-Peter Clausen
2016-11-14 17:26 ` Jonathan Cameron
2016-11-14 16:58 ` Linus Walleij
2016-11-14 18:53 ` Lars-Peter Clausen
2016-11-14 22:15 ` Jonathan Cameron
2016-11-14 23:12 ` Linus Walleij
2016-11-19 12:32 ` Jonathan Cameron
2016-11-11 6:34 ` [PATCH 2/2] staging: iio: ad7606: move out of staging Eva Rachel Retuya
2016-11-11 14:22 ` Lars-Peter Clausen
2016-11-12 14:26 ` Jonathan Cameron
2016-11-12 14:32 ` Eva Rachel Retuya [this message]
2016-11-12 14:42 ` Jonathan Cameron
2016-11-11 16:10 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112143242.GB2214@Socrates-DK \
--to=eraretuya@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).