From: Tony Lindgren <tony@atomide.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Nicolae Rosia <Nicolae_Rosia@mentor.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: twl4030-madc: convert to DT only
Date: Sat, 12 Nov 2016 09:56:19 -0800 [thread overview]
Message-ID: <20161112175619.GE7129@atomide.com> (raw)
In-Reply-To: <18487c16-04ee-b65a-c773-27a2965db8b3@kernel.org>
* Jonathan Cameron <jic23@kernel.org> [161112 05:21]:
> On 12/11/16 10:21, Nicolae Rosia wrote:
> > All users are DT only and it makes no sense to keep dead code.
> > twl4030_madc_platform_data is unused and can now be removed
> > from include/i2c/twl.h
> >
> Whilst we don't 'have' to be nice to out of tree users, the advantage
> in code reduction here is pretty limited.
>
> So I'm doubtful unless Tony confirms that this is a sensible move and that
> the rest of the elements of twl4030 support are going the same way.
Yeah well mach-omap2 is all device tree only now. We still do have
the platform_data init around in the unlikely case we still need
to revert it for some regression. But I'm queuing patches for v4.10
to drop the rest of the platform_data based init and will merge
them assuming no problems.
If this helps cleaning up the rest of the twl related code then
sure makes sense to me. If this is not blocking other clean-up,
maybe wait until v4.11 merge window to be safe on this one.
Regards,
Tony
next prev parent reply other threads:[~2016-11-12 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 10:21 [PATCH] iio: twl4030-madc: convert to DT only Nicolae Rosia
2016-11-12 13:21 ` Jonathan Cameron
2016-11-12 17:56 ` Tony Lindgren [this message]
2016-11-12 19:41 ` Nicolae Rosia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112175619.GE7129@atomide.com \
--to=tony@atomide.com \
--cc=Nicolae_Rosia@mentor.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).