From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Cameron <jic23@kernel.org>, Jon Brenner <jbrenner@taosinc.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Brian Masney <masneyb@onstation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eva Rachel Retuya <eraretuya@gmail.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] iio: tsl2583: off by one in in_illuminance_lux_table_store()
Date: Fri, 18 Nov 2016 14:51:54 +0300 [thread overview]
Message-ID: <20161118115153.GC3281@mwanda> (raw)
The value[] array has "max_ints" elements so this should be >= instead
of >.
Fixes: ac4f6eee8fe8 ("staging: iio: TAOS tsl258x: Device driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index 0b87f6a..faef6bd 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -580,7 +580,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
* and the last table entry is all 0.
*/
n = value[0];
- if ((n % 3) || n < 6 || n > max_ints) {
+ if ((n % 3) || n < 6 || n >= max_ints) {
dev_err(dev,
"%s: The number of entries in the lux table must be a multiple of 3 and within the range [6, %d]\n",
__func__, max_ints);
next reply other threads:[~2016-11-18 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:51 Dan Carpenter [this message]
2016-11-18 14:03 ` [patch] iio: tsl2583: off by one in in_illuminance_lux_table_store() Brian Masney
2016-11-24 13:38 ` [patch] iio: tsl2583: make array large enough Dan Carpenter
2016-11-24 15:48 ` Brian Masney
2016-11-24 16:54 ` walter harms
2016-11-24 17:51 ` Brian Masney
2016-11-24 20:12 ` Jonathan Cameron
2016-11-25 8:53 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118115153.GC3281@mwanda \
--to=dan.carpenter@oracle.com \
--cc=eraretuya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrenner@taosinc.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).