From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:53912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753197AbcKYM7q (ORCPT ); Fri, 25 Nov 2016 07:59:46 -0500 Date: Fri, 25 Nov 2016 13:59:14 +0100 From: Benjamin Tissoires To: Bastien Nocera Cc: Jiri Kosina , Srinivas Pandruvada , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3 Message-ID: <20161125125914.GY2119@mail.corp.redhat.com> References: <1480068224-32224-1-git-send-email-benjamin.tissoires@redhat.com> <1480068224-32224-2-git-send-email-benjamin.tissoires@redhat.com> <1480076165.16940.21.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1480076165.16940.21.camel@hadess.net> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Nov 25 2016 or thereabouts, Bastien Nocera wrote: > On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote: > > One more device requiring a quirk :/ > > > > Signed-off-by: Benjamin Tissoires > > Tested-by: Bastien Nocera > > > --- > >  drivers/hid/hid-sensor-hub.c | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor- > > hub.c > > index 50aad26..f9440b6 100644 > > --- a/drivers/hid/hid-sensor-hub.c > > +++ b/drivers/hid/hid-sensor-hub.c > > @@ -798,6 +798,9 @@ static const struct hid_device_id > > sensor_hub_devices[] = { > >   { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, > > USB_VENDOR_ID_MICROSOFT, > >   USB_DEVICE_ID_MS_TYPE_COVER_2), > >   .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > > + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, > > USB_VENDOR_ID_MICROSOFT, > > + 0x07bd), /* Microsoft Surface 3 TypeCover */ > > The sensor is not in the TypeCover though, it's in the main device. Oops, yes, sorry. I have been traumatised by the type cover apparently :) Benjamin > > > + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > >   { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, > > USB_VENDOR_ID_STM_0, > >   USB_DEVICE_ID_STM_HID_SENSOR), > >   .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},