* [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments
@ 2016-12-07 17:44 Nizam Haider
2016-12-10 17:51 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Nizam Haider @ 2016-12-07 17:44 UTC (permalink / raw)
To: pmeerw
Cc: lars, Michael.Hennerich, jic23, knaack.h, gregkh, linux-iio,
devel, linux-kernel, Nizam Haider, Nizam Haider
according to datasheet complete control register is of 2 bytes.
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
Signed-off-by: Nizam Haider <nijam.h@hcl.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index 3892a74..f39e03a 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -23,8 +23,8 @@
#include <linux/iio/kfifo_buf.h>
/* AD5933/AD5934 Registers */
-#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 2 bytes */
-#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 2 bytes */
+#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 1 byte */
+#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 1 byte */
#define AD5933_REG_FREQ_START 0x82 /* R/W, 3 bytes */
#define AD5933_REG_FREQ_INC 0x85 /* R/W, 3 bytes */
#define AD5933_REG_INC_NUM 0x88 /* R/W, 2 bytes, 9 bit */
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments
2016-12-07 17:44 [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments Nizam Haider
@ 2016-12-10 17:51 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-12-10 17:51 UTC (permalink / raw)
To: Nizam Haider, pmeerw
Cc: lars, Michael.Hennerich, knaack.h, gregkh, linux-iio, devel,
linux-kernel, Nizam Haider
On 07/12/16 17:44, Nizam Haider wrote:
> according to datasheet complete control register is of 2 bytes.
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
>
> Signed-off-by: Nizam Haider <nijam.h@hcl.com>
Applied to the togreg branch of iio.git - initially pushed out as testing so the
autobuilders can completely ignore this patch ;)
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3892a74..f39e03a 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -23,8 +23,8 @@
> #include <linux/iio/kfifo_buf.h>
>
> /* AD5933/AD5934 Registers */
> -#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 2 bytes */
> -#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 2 bytes */
> +#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 1 byte */
> +#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 1 byte */
> #define AD5933_REG_FREQ_START 0x82 /* R/W, 3 bytes */
> #define AD5933_REG_FREQ_INC 0x85 /* R/W, 3 bytes */
> #define AD5933_REG_INC_NUM 0x88 /* R/W, 2 bytes, 9 bit */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-10 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 17:44 [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments Nizam Haider
2016-12-10 17:51 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).