From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Magnus Damm <magnus.damm@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCHv2] iio: adc: Add Maxim MAX11100 driver
Date: Tue, 13 Dec 2016 16:53:27 +0100 [thread overview]
Message-ID: <20161213155327.GA1451@katana> (raw)
In-Reply-To: <CAMuHMdUCuBs9Fm+YvsqEc1J_a_2sgg104DDBf39oUD2JQRxXtg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
> > +struct max11100_state {
> > + const struct max11100_chip_desc *desc;
> > + struct spi_device *spi;
> > + int vref_uv;
>
> unsi
> It's good practice to move the smaller members to the end of the structure,
> to avoid gaps due to alignment rules (struct mutex needs to be 64-bit aligned
> on 64-bit platforms).
One option. Another idea is to put the most used members to the front to
increase chances of being in the same cacheline.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-13 15:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 16:30 [PATCH] iio: Add Maxim MAX11100 driver Jacopo Mondi
2016-12-06 21:00 ` Peter Meerwald-Stadler
2016-12-07 8:15 ` Geert Uytterhoeven
2016-12-07 8:29 ` jacopo
2016-12-07 12:22 ` Geert Uytterhoeven
2016-12-10 17:54 ` Jonathan Cameron
2016-12-10 18:04 ` Jonathan Cameron
2016-12-12 18:11 ` jacopo
2016-12-13 12:37 ` [PATCHv2] iio: adc: " Jacopo Mondi
2016-12-13 13:21 ` Geert Uytterhoeven
2016-12-13 15:53 ` Wolfram Sang [this message]
2016-12-30 16:09 ` Jonathan Cameron
2016-12-14 11:54 ` jacopo
2016-12-14 12:14 ` Geert Uytterhoeven
2016-12-13 20:33 ` Peter Meerwald-Stadler
2016-12-14 12:00 ` jacopo
2016-12-30 16:31 ` Jonathan Cameron
2017-01-02 9:19 ` jacopo mondi
2017-01-02 18:02 ` Jonathan Cameron
2016-12-30 16:08 ` Jonathan Cameron
2017-01-02 8:41 ` jacopo mondi
2016-12-30 16:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213155327.GA1451@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).