Linux IIO development
 help / color / mirror / Atom feed
From: Josef Gajdusek <atx@atx.name>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, maitysanchayan@gmail.com,
	gregor.boirie@parrot.com, linux-kernel@vger.kernel.org,
	rui.zhang@intel.com, marxin.liska@gmail.com, marex@denx.de,
	atx@atx.name
Subject: [PATCH] iio: light: acpi-als: Properly enable on ASUS Zenbooks
Date: Wed, 18 Jan 2017 17:39:53 +0100	[thread overview]
Message-ID: <20170118161254.GA17344@rick.lan> (raw)

ASUS Zenbooks need several special ACPI calls to enable the ALS peripheral.
Otherwise, reads just return 0.

Signed-off-by: Josef Gajdusek <atx@atx.name>
---
 drivers/iio/light/acpi-als.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
index f0b47c5..1fe2cd8 100644
--- a/drivers/iio/light/acpi-als.c
+++ b/drivers/iio/light/acpi-als.c
@@ -39,6 +39,9 @@
 #define ACPI_ALS_DEVICE_NAME		"acpi-als"
 #define ACPI_ALS_NOTIFY_ILLUMINANCE	0x80
 
+#define ACPI_ALS_ASUS_TALS		"\\_SB.PCI0.LPCB.EC0.TALS"
+#define ACPI_ALS_ASUS_ALSC		"\\_SB.ATKD.ALSC"
+
 ACPI_MODULE_NAME("acpi-als");
 
 /*
@@ -180,6 +183,8 @@ static int acpi_als_add(struct acpi_device *device)
 	struct acpi_als *als;
 	struct iio_dev *indio_dev;
 	struct iio_buffer *buffer;
+	acpi_handle handle_tals, handle_alsc;
+	acpi_status status_tals, status_alsc;
 
 	indio_dev = devm_iio_device_alloc(&device->dev, sizeof(*als));
 	if (!indio_dev)
@@ -191,6 +196,18 @@ static int acpi_als_add(struct acpi_device *device)
 	als->device = device;
 	mutex_init(&als->lock);
 
+	/* ASUS Zenbooks need this to enable ALS */
+	status_tals = acpi_get_handle(NULL, ACPI_ALS_ASUS_TALS, &handle_tals);
+	status_alsc = acpi_get_handle(NULL, ACPI_ALS_ASUS_ALSC, &handle_alsc);
+	/* So far only devices with both have been observed */
+	if (ACPI_SUCCESS(status_tals) ^ ACPI_SUCCESS(status_alsc))
+		dev_warn(&device->dev, "Attempting to enable ACPI ALS, but found only one of \""
+			 ACPI_ALS_ASUS_TALS "\" and \"" ACPI_ALS_ASUS_ALSC "\"");
+	if (ACPI_SUCCESS(status_tals))
+		acpi_execute_simple_method(handle_tals, NULL, 1);
+	if (ACPI_SUCCESS(status_alsc))
+		acpi_execute_simple_method(handle_alsc, NULL, 1);
+
 	indio_dev->name = ACPI_ALS_DEVICE_NAME;
 	indio_dev->dev.parent = &device->dev;
 	indio_dev->info = &acpi_als_info;
-- 
2.10.2


             reply	other threads:[~2017-01-18 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 16:39 Josef Gajdusek [this message]
2017-01-18 20:26 ` [PATCH] iio: light: acpi-als: Properly enable on ASUS Zenbooks Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118161254.GA17344@rick.lan \
    --to=atx@atx.name \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=marex@denx.de \
    --cc=marxin.liska@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox