* [PATCH -next] iio: common: ssp_sensors: accel: use devm_iio_device_register()
@ 2017-01-22 16:36 Wei Yongjun
2017-01-28 12:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-01-22 16:36 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Julia Lawall
Cc: Wei Yongjun, linux-iio
From: Wei Yongjun <weiyongjun1@huawei.com>
Use devm_iio_device_register() for IIO subsystem device
registration and delete the remove function since there
is no need after this change.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/iio/accel/ssp_accel_sensor.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/iio/accel/ssp_accel_sensor.c b/drivers/iio/accel/ssp_accel_sensor.c
index 6b54008..dd6ece8 100644
--- a/drivers/iio/accel/ssp_accel_sensor.c
+++ b/drivers/iio/accel/ssp_accel_sensor.c
@@ -136,7 +136,7 @@ static int ssp_accel_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, indio_dev);
- ret = iio_device_register(indio_dev);
+ ret = devm_iio_device_register(&pdev->dev, indio_dev);
if (ret < 0)
return ret;
@@ -146,21 +146,11 @@ static int ssp_accel_probe(struct platform_device *pdev)
return 0;
}
-static int ssp_accel_remove(struct platform_device *pdev)
-{
- struct iio_dev *indio_dev = platform_get_drvdata(pdev);
-
- iio_device_unregister(indio_dev);
-
- return 0;
-}
-
static struct platform_driver ssp_accel_driver = {
.driver = {
.name = SSP_ACCEL_NAME,
},
.probe = ssp_accel_probe,
- .remove = ssp_accel_remove,
};
module_platform_driver(ssp_accel_driver);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] iio: common: ssp_sensors: accel: use devm_iio_device_register()
2017-01-22 16:36 [PATCH -next] iio: common: ssp_sensors: accel: use devm_iio_device_register() Wei Yongjun
@ 2017-01-28 12:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-01-28 12:15 UTC (permalink / raw)
To: Wei Yongjun, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Julia Lawall
Cc: Wei Yongjun, linux-iio
On 22/01/17 16:36, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Use devm_iio_device_register() for IIO subsystem device
> registration and delete the remove function since there
> is no need after this change.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/ssp_accel_sensor.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/iio/accel/ssp_accel_sensor.c b/drivers/iio/accel/ssp_accel_sensor.c
> index 6b54008..dd6ece8 100644
> --- a/drivers/iio/accel/ssp_accel_sensor.c
> +++ b/drivers/iio/accel/ssp_accel_sensor.c
> @@ -136,7 +136,7 @@ static int ssp_accel_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, indio_dev);
>
> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(&pdev->dev, indio_dev);
> if (ret < 0)
> return ret;
>
> @@ -146,21 +146,11 @@ static int ssp_accel_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int ssp_accel_remove(struct platform_device *pdev)
> -{
> - struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> -
> - iio_device_unregister(indio_dev);
> -
> - return 0;
> -}
> -
> static struct platform_driver ssp_accel_driver = {
> .driver = {
> .name = SSP_ACCEL_NAME,
> },
> .probe = ssp_accel_probe,
> - .remove = ssp_accel_remove,
> };
>
> module_platform_driver(ssp_accel_driver);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-28 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 16:36 [PATCH -next] iio: common: ssp_sensors: accel: use devm_iio_device_register() Wei Yongjun
2017-01-28 12:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).