From: Pavel Machek <pavel@ucw.cz>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@armlinux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Michael Welling" <mwelling@ieee.org>,
"Mika Penttilä" <mika.penttila@nextfour.com>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Igor Grinberg" <grinberg@compulab.co.il>,
"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Alexander Stein" <alexander.stein@systec-electronic.com>,
"Eric Engestrom" <eric@engestrom.ch>,
"Hans de Goede" <hdegoede@redhat.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Petr Cvek" <petr.cvek@tul.cz>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Nick Dyer" <nick@shmanahar.org>,
"Siebren Vroegindeweij" <siebren.vroegindeweij@hotmail.com>,
"Michel Verlaan" <michel.verl@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
letux-kernel@openphoenux.org, linux-iio@vger.kernel.org,
kernel@pyra-handheld.com,
"Aaro Koskinen" <aaro.koskinen@nokia.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Andrey Gelman" <andrey.gelman@compulab.co.il>,
"Haibo Chen" <haibo.chen@freescale.com>
Subject: Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation
Date: Sun, 19 Feb 2017 23:19:30 +0100 [thread overview]
Message-ID: <20170219221930.GA1568@amd> (raw)
In-Reply-To: <6DF7B03A-8B63-422C-9561-69A34A7FBF35@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]
hi!
> >> But as said I don't think we need float or fixed point for practical systems
> >> at all.
> >
> > So you are going to loose precision. And if userspace decides to
> > calibrate it slightly differently from kernel, lost precision will
> > matter.
>
> Really?
Really.
> Example:
>
> ADC values go 100 .. 3995 (i.e. touch margin is 100 steps in pre-calibration)
>
> This is scaled to let's say 0..640.
Ok. Now userspace realizes that kernel alignemnt is off, and it would
want to scale it to 1..642. That will mean that single pixel will be
inaccessible, right?
> > No. You have to design interface such that they _can_ be improved, and
> > what you propose does not work that way.
>
> It works. Please do real world tests...
You do a real world test on N900, and propose upgrade path.
> > Yes. I want to prevent you from pushing crap into the kernel.
>
> Crap? Well, we have discussed this driver for months here on the list and
> after a lot of improvements we came up to v9.
>
> And you still think it is crap and none of the other reviewers has noticed?
I'm pretty sure you will not be able to push calibration into kernel.
> > Userspace has to know how to do the calibration _anyway_ (for
> > other hardware),
>
> What for? I do not understand which other hardware you are talking about.
>
> On our devices there is only one touch glued to the panel and that one
> has to be calibrated. Ideally before the user gets the device into his
> hands => precalibration...
>
> If you connect a digitizer, then that one has to be calibrated of course,
> but it is not glued onto the display panel. Hence it is a different
> issue.
It is actually same issue. One kernel interface should work for all
the touchscreens.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-02-19 22:27 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:53 [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2017-01-09 17:43 ` Rob Herring
2017-01-28 19:33 ` Dmitry Torokhov
2017-01-28 21:44 ` H. Nikolaus Schaller
2017-02-17 20:40 ` Dmitry Torokhov
2017-02-18 3:22 ` Sebastian Reichel
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 23:44 ` Sebastian Reichel
2017-02-19 12:07 ` H. Nikolaus Schaller
2017-02-19 20:15 ` Sebastian Reichel
2017-02-20 16:49 ` H. Nikolaus Schaller
2017-02-18 7:45 ` [Letux-kernel] " Andreas Kemnade
2017-02-18 9:15 ` Pavel Machek
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 18:08 ` Pavel Machek
2017-02-18 19:17 ` H. Nikolaus Schaller
2017-02-18 22:54 ` Pavel Machek
2017-02-19 12:05 ` H. Nikolaus Schaller
2017-02-19 14:17 ` Pavel Machek
2017-02-19 17:04 ` H. Nikolaus Schaller
2017-02-19 17:15 ` Pavel Machek
2017-02-19 17:51 ` H. Nikolaus Schaller
2017-02-19 19:05 ` Pavel Machek
2017-02-19 19:31 ` H. Nikolaus Schaller
2017-02-19 20:57 ` Pavel Machek
2017-02-19 22:01 ` H. Nikolaus Schaller
2017-02-19 22:19 ` Pavel Machek [this message]
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:29 ` Pavel Machek
2017-02-20 20:20 ` H. Nikolaus Schaller
2017-02-20 22:26 ` Petr Cvek
2017-02-21 8:29 ` H. Nikolaus Schaller
2017-02-19 22:29 ` [Letux-kernel] " Andreas Kemnade
2017-02-19 22:39 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:32 ` Pavel Machek
2017-02-20 20:22 ` H. Nikolaus Schaller
2017-02-20 20:50 ` H. Nikolaus Schaller
2017-02-18 11:32 ` H. Nikolaus Schaller
2017-02-20 1:07 ` Dmitry Torokhov
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:42 ` Pali Rohár
2017-02-20 20:35 ` H. Nikolaus Schaller
2017-02-20 21:07 ` Pali Rohár
2017-02-20 21:24 ` H. Nikolaus Schaller
2017-02-20 21:54 ` Pali Rohár
2017-02-21 6:42 ` H. Nikolaus Schaller
2017-02-21 8:53 ` Pali Rohár
2017-02-20 21:08 ` Pali Rohár
2017-02-20 21:27 ` H. Nikolaus Schaller
2017-02-20 21:50 ` Dmitry Torokhov
2017-02-20 22:21 ` Petr Cvek
2017-02-20 22:24 ` Dmitry Torokhov
2017-02-21 6:56 ` H. Nikolaus Schaller
2017-02-20 22:45 ` Pali Rohár
2017-02-21 6:36 ` H. Nikolaus Schaller
2017-02-21 9:09 ` Pali Rohár
2017-02-21 17:07 ` [Letux-kernel] " Andreas Kemnade
2017-02-20 22:04 ` Pali Rohár
2017-02-21 6:49 ` H. Nikolaus Schaller
2017-02-21 7:14 ` H. Nikolaus Schaller
2017-02-21 8:47 ` Pali Rohár
2017-02-21 8:57 ` [Letux-kernel] " Christ van Willegen
2017-02-21 11:07 ` Pavel Machek
2016-12-28 14:53 ` [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2017-02-17 20:52 ` Dmitry Torokhov
2016-12-28 14:53 ` [PATCH v9 3/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 4/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 5/8] dt-bindings: input: move ads7846 bindings to touchscreen subdirectory H. Nikolaus Schaller
2017-02-23 9:54 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2017-01-28 19:35 ` Dmitry Torokhov
2017-01-29 8:39 ` H. Nikolaus Schaller
2017-01-29 18:01 ` Dmitry Torokhov
2017-01-29 18:25 ` H. Nikolaus Schaller
2017-02-01 20:20 ` H. Nikolaus Schaller
2017-02-01 21:14 ` Javier Martinez Canillas
2017-02-01 22:28 ` Dmitry Torokhov
2017-02-01 22:50 ` Javier Martinez Canillas
2017-02-02 5:47 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 7/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 8/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
2016-12-30 20:36 ` Jonathan Cameron
2017-02-17 21:27 ` Dmitry Torokhov
2017-02-18 11:35 ` H. Nikolaus Schaller
2017-01-16 6:34 ` [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2017-01-21 13:08 ` Jonathan Cameron
2017-01-21 13:17 ` H. Nikolaus Schaller
2017-01-28 18:16 ` [Letux-kernel] " H. Nikolaus Schaller
2017-02-12 15:18 ` H. Nikolaus Schaller
2017-02-15 14:03 ` H. Nikolaus Schaller
2017-02-17 20:43 ` Dmitry Torokhov
2017-02-18 11:30 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170219221930.GA1568@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@nokia.com \
--cc=afd@ti.com \
--cc=alexander.stein@systec-electronic.com \
--cc=andrey.gelman@compulab.co.il \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=benjamin.tissoires@redhat.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric@engestrom.ch \
--cc=grinberg@compulab.co.il \
--cc=haibo.chen@freescale.com \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=hns@goldelico.com \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michel.verl@gmail.com \
--cc=mika.penttila@nextfour.com \
--cc=mwelling@ieee.org \
--cc=nick@shmanahar.org \
--cc=pali.rohar@gmail.com \
--cc=petr.cvek@tul.cz \
--cc=robh+dt@kernel.org \
--cc=siebren.vroegindeweij@hotmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).