From: Lee Jones <lee.jones@linaro.org>
To: Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
wens@csie.org, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
icenowy@aosc.xyz, liam@networkimprov.net,
thomas.petazzoni@free-electrons.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [RESEND PATCH v4 1/9] mfd: axp20x: correct name of temperature data ADC registers
Date: Mon, 20 Mar 2017 10:43:29 +0000 [thread overview]
Message-ID: <20170320104329.ymusypmxljnitmwr@dell> (raw)
In-Reply-To: <20170320081653.8884-2-quentin.schulz@free-electrons.com>
On Mon, 20 Mar 2017, Quentin Schulz wrote:
> The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
> internal temperature of the PMIC.
>
> This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
> to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> added in v2
>
> drivers/mfd/axp20x.c | 2 +-
> include/linux/mfd/axp20x.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0512900..e02edf1 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -101,7 +101,7 @@ static const struct regmap_range axp22x_volatile_ranges[] = {
> regmap_reg_range(AXP20X_PWR_INPUT_STATUS, AXP20X_PWR_OP_MODE),
> regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE),
> regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
> - regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L),
> + regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L),
> regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES),
> };
>
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index 0d9a1ff..dc8798c 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -228,8 +228,8 @@ enum axp20x_variants {
> #define AXP20X_OCV_MAX 0xf
>
> /* AXP22X specific registers */
> -#define AXP22X_PMIC_ADC_H 0x56
> -#define AXP22X_PMIC_ADC_L 0x57
> +#define AXP22X_PMIC_TEMP_H 0x56
> +#define AXP22X_PMIC_TEMP_L 0x57
> #define AXP22X_TS_ADC_H 0x58
> #define AXP22X_TS_ADC_L 0x59
> #define AXP22X_BATLOW_THRES1 0xe6
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-20 10:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 8:16 [RESEND PATCH v4 0/9] add support for AXP20X and AXP22X power supply drivers Quentin Schulz
2017-03-20 8:16 ` [RESEND PATCH v4 1/9] mfd: axp20x: correct name of temperature data ADC registers Quentin Schulz
2017-03-20 10:43 ` Lee Jones [this message]
2017-03-20 8:16 ` [RESEND PATCH v4 2/9] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs Quentin Schulz
2017-03-22 4:34 ` Chen-Yu Tsai
2017-03-22 6:31 ` Jonathan Cameron
2017-03-23 9:35 ` Sebastian Reichel
2017-03-23 9:52 ` Chen-Yu Tsai
2017-03-24 7:55 ` Quentin Schulz
2017-03-24 8:01 ` [linux-sunxi] " Chen-Yu Tsai
2017-03-20 8:16 ` [RESEND PATCH v4 3/9] mfd: axp20x: add ADC cells for AXP20X and AXP22X PMICs Quentin Schulz
2017-03-20 10:43 ` Lee Jones
2017-03-20 8:16 ` [RESEND PATCH v4 4/9] mfd: axp20x: add AC power supply cells for " Quentin Schulz
2017-03-20 10:43 ` Lee Jones
2017-03-20 8:16 ` [RESEND PATCH v4 5/9] ARM: dtsi: axp209: add AC power supply subnode Quentin Schulz
2017-03-20 8:16 ` [RESEND PATCH v4 6/9] ARM: dtsi: axp22x: " Quentin Schulz
2017-03-20 8:16 ` [RESEND PATCH v4 7/9] ARM: dts: sun8i: sina33: enable ACIN " Quentin Schulz
2017-03-20 8:16 ` [RESEND PATCH v4 8/9] ARM: sun5i: chip: " Quentin Schulz
2017-03-20 8:16 ` [RESEND PATCH v4 9/9] mfd: axp20x: add CHRG_CTRL1/2/3 to writeable regs for AXP20X/AXP22X Quentin Schulz
2017-03-20 10:44 ` Lee Jones
2017-03-22 7:11 ` [RESEND PATCH v4 0/9] add support for AXP20X and AXP22X power supply drivers Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320104329.ymusypmxljnitmwr@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=liam@networkimprov.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox