From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org
Subject: spear_adc driver help needed ?
Date: Thu, 18 May 2017 09:41:46 +0200 [thread overview]
Message-ID: <20170518094146.6504821a@free-electrons.com> (raw)
Hello Jonathan,
I've been working on a SPEAr600 platform recently, which uses the
spear_adc driver, and was about to start working on moving the driver
out of staging... only to discover in 4.12-rc1 that you already moved
it out of staging.
In the commit log that moves it out of staging, you're saying:
There are some unanswered questions due to disagreements between the code
and various datasheets (including between different datasheets for the same
part).
I don't think that is necessarily a reason to keep it in staging however.
I'm partly posting this patch inorder to reignite debate and with a bit
of luck find someone who has one of these to test!
What are the unanswered questions you are talking about?
Also, I am currently using the driver on a SPEAr600 device, so I can do
some testing.
The driver has support for the SPEAr3xx, but it isn't used anywhere:
there is no compatible string for it, and nowhere is old-style probing
used for "spear-adc".
So I'm thinking of:
- Dropping SPEAr3xx support, because it's unused. This will also
remove the ugly checks done on the compatible string all over the
place.
- Moving to a "base + offset" style of register accesses, rather than
the struct-based accesses.
What do you think ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next reply other threads:[~2017-05-18 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 7:41 Thomas Petazzoni [this message]
2017-05-21 14:33 ` spear_adc driver help needed ? Jonathan Cameron
2017-05-22 5:37 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518094146.6504821a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox