From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muru.com ([72.249.23.125]:48530 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbdETQCp (ORCPT ); Sat, 20 May 2017 12:02:45 -0400 Date: Sat, 20 May 2017 09:02:40 -0700 From: Tony Lindgren To: Matt Ranostay Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "open list:IIO SUBSYSTEM AND..." , linux-omap@vger.kernel.org, Marcel Partap , Michael Scott , Sebastian Reichel Subject: Re: [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature Message-ID: <20170520160240.GL10472@atomide.com> References: <20170519034035.16795-1-tony@atomide.com> <20170519034035.16795-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org * Matt Ranostay [170519 22:55]: > On Thu, May 18, 2017 at 8:40 PM, Tony Lindgren wrote: > > enum cpcap_adc_channel { > > /* Bank0 channels */ > > - CPCAP_ADC_AD0_BATTDETB, /* Battery detection */ > > + CPCAP_ADC_AD0_BATTDETB, /* Battery temperature */ > > Since this doesn't mean battery detection anymore I'd recommend > renaming to CPCAP_ADC_AD0_BATTEMP or similar. OK I'll change it to just CPCAP_ADC_AD0 as it seems it's use has changed across revisions or products. Regards, Tony