* [PATCH] iio:adc:lpc32xx Handle return value of clk_prepare_enable
@ 2017-05-30 11:05 Arvind Yadav
2017-06-03 8:30 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-05-30 11:05 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, vz, slemieux.tyco
Cc: linux-iio, linux-arm-kernel, linux-kernel
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/iio/adc/lpc32xx_adc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
index 0de709b..6a5b9a9 100644
--- a/drivers/iio/adc/lpc32xx_adc.c
+++ b/drivers/iio/adc/lpc32xx_adc.c
@@ -76,10 +76,14 @@ static int lpc32xx_read_raw(struct iio_dev *indio_dev,
long mask)
{
struct lpc32xx_adc_state *st = iio_priv(indio_dev);
-
+ int ret;
if (mask == IIO_CHAN_INFO_RAW) {
mutex_lock(&indio_dev->mlock);
- clk_prepare_enable(st->clk);
+ ret = clk_prepare_enable(st->clk);
+ if (ret) {
+ mutex_unlock(&indio_dev->mlock);
+ return ret;
+ }
/* Measurement setup */
__raw_writel(LPC32XXAD_INTERNAL | (chan->address) |
LPC32XXAD_REFp | LPC32XXAD_REFm,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio:adc:lpc32xx Handle return value of clk_prepare_enable
2017-05-30 11:05 [PATCH] iio:adc:lpc32xx Handle return value of clk_prepare_enable Arvind Yadav
@ 2017-06-03 8:30 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-06-03 8:30 UTC (permalink / raw)
To: Arvind Yadav
Cc: knaack.h, lars, pmeerw, vz, slemieux.tyco, linux-iio,
linux-arm-kernel, linux-kernel
On Tue, 30 May 2017 16:35:27 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/lpc32xx_adc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
> index 0de709b..6a5b9a9 100644
> --- a/drivers/iio/adc/lpc32xx_adc.c
> +++ b/drivers/iio/adc/lpc32xx_adc.c
> @@ -76,10 +76,14 @@ static int lpc32xx_read_raw(struct iio_dev *indio_dev,
> long mask)
> {
> struct lpc32xx_adc_state *st = iio_priv(indio_dev);
> -
> + int ret;
> if (mask == IIO_CHAN_INFO_RAW) {
> mutex_lock(&indio_dev->mlock);
> - clk_prepare_enable(st->clk);
> + ret = clk_prepare_enable(st->clk);
> + if (ret) {
> + mutex_unlock(&indio_dev->mlock);
> + return ret;
> + }
> /* Measurement setup */
> __raw_writel(LPC32XXAD_INTERNAL | (chan->address) |
> LPC32XXAD_REFp | LPC32XXAD_REFm,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-03 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30 11:05 [PATCH] iio:adc:lpc32xx Handle return value of clk_prepare_enable Arvind Yadav
2017-06-03 8:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).