* [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer @ 2017-05-28 11:24 Paolo Cretaro 2017-05-28 14:43 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Paolo Cretaro @ 2017-05-28 11:24 UTC (permalink / raw) To: jic23; +Cc: linux-iio, linux-kernel, Paolo Cretaro Fix sparse warning: Using plain integer as NULL pointer Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> --- drivers/iio/adc/meson_saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index 81cd39a57fe3..fb3f67a9ae1f 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) if (!meson_sar_adc_get_fifo_count(indio_dev)) break; - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); } } -- 2.13.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-05-28 11:24 [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro @ 2017-05-28 14:43 ` Jonathan Cameron 2017-05-28 17:52 ` Paolo Cretaro 2017-05-28 21:17 ` Martin Blumenstingl 0 siblings, 2 replies; 7+ messages in thread From: Jonathan Cameron @ 2017-05-28 14:43 UTC (permalink / raw) To: Paolo Cretaro; +Cc: linux-iio, linux-kernel, Martin Blumenstingl On Sun, 28 May 2017 13:24:38 +0200 Paolo Cretaro <paolocretaro@gmail.com> wrote: > Fix sparse warning: Using plain integer as NULL pointer > > Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> This looks fine to me, but ideally you should always try to include the driver author - particularly in the case of patches to a recent driver such as this one. To that end I've cc'd Martin. Jonathan > --- > drivers/iio/adc/meson_saradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 81cd39a57fe3..fb3f67a9ae1f 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) > if (!meson_sar_adc_get_fifo_count(indio_dev)) > break; > > - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); > + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); > } > } > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-05-28 14:43 ` Jonathan Cameron @ 2017-05-28 17:52 ` Paolo Cretaro 2017-05-28 21:17 ` Martin Blumenstingl 1 sibling, 0 replies; 7+ messages in thread From: Paolo Cretaro @ 2017-05-28 17:52 UTC (permalink / raw) To: Jonathan Cameron; +Cc: linux-iio, linux-kernel, Martin Blumenstingl On 28/05/2017 16:43, Jonathan Cameron wrote: > On Sun, 28 May 2017 13:24:38 +0200 > Paolo Cretaro <paolocretaro@gmail.com> wrote: > >> Fix sparse warning: Using plain integer as NULL pointer >> >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> > This looks fine to me, but ideally you should always try to include > the driver author - particularly in the case of patches to a recent > driver such as this one. Sure, thanks for pointing this out, I just felt a bit embarrassed to bother too many people with such a trivial patch. Paolo > > To that end I've cc'd Martin. > > Jonathan >> --- >> drivers/iio/adc/meson_saradc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> index 81cd39a57fe3..fb3f67a9ae1f 100644 >> --- a/drivers/iio/adc/meson_saradc.c >> +++ b/drivers/iio/adc/meson_saradc.c >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) >> if (!meson_sar_adc_get_fifo_count(indio_dev)) >> break; >> >> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); >> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); >> } >> } >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-05-28 14:43 ` Jonathan Cameron 2017-05-28 17:52 ` Paolo Cretaro @ 2017-05-28 21:17 ` Martin Blumenstingl 2017-06-03 8:52 ` Jonathan Cameron 1 sibling, 1 reply; 7+ messages in thread From: Martin Blumenstingl @ 2017-05-28 21:17 UTC (permalink / raw) To: Jonathan Cameron; +Cc: Paolo Cretaro, linux-iio, linux-kernel Hi Paolo, Hi Jonathan, On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@kernel.org> wrote: > On Sun, 28 May 2017 13:24:38 +0200 > Paolo Cretaro <paolocretaro@gmail.com> wrote: > >> Fix sparse warning: Using plain integer as NULL pointer >> >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> > This looks fine to me, but ideally you should always try to include > the driver author - particularly in the case of patches to a recent > driver such as this one. > > To that end I've cc'd Martin. thanks for spotting this (and providing a patch to fix it) this looks good to me, so: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> if you can wait until next weekend then I can also test this on real hardware. > Jonathan >> --- >> drivers/iio/adc/meson_saradc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> index 81cd39a57fe3..fb3f67a9ae1f 100644 >> --- a/drivers/iio/adc/meson_saradc.c >> +++ b/drivers/iio/adc/meson_saradc.c >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) >> if (!meson_sar_adc_get_fifo_count(indio_dev)) >> break; >> >> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); >> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); >> } >> } >> > Regards, Martin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-05-28 21:17 ` Martin Blumenstingl @ 2017-06-03 8:52 ` Jonathan Cameron 2017-06-04 13:32 ` Martin Blumenstingl 0 siblings, 1 reply; 7+ messages in thread From: Jonathan Cameron @ 2017-06-03 8:52 UTC (permalink / raw) To: Martin Blumenstingl; +Cc: Paolo Cretaro, linux-iio, linux-kernel On Sun, 28 May 2017 23:17:57 +0200 Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Hi Paolo, Hi Jonathan, > > On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@kernel.org> wrote: > > On Sun, 28 May 2017 13:24:38 +0200 > > Paolo Cretaro <paolocretaro@gmail.com> wrote: > > > >> Fix sparse warning: Using plain integer as NULL pointer > >> > >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> > > This looks fine to me, but ideally you should always try to include > > the driver author - particularly in the case of patches to a recent > > driver such as this one. > > > > To that end I've cc'd Martin. > thanks for spotting this (and providing a patch to fix it) > this looks good to me, so: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > if you can wait until next weekend then I can also test this on real hardware. I've applied it to the togreg branch of iio.git but as that always goes out as testing for at least a few days first (which I will happily rebase) give me a shout if anything goes wrong! Jonathan > > > Jonathan > >> --- > >> drivers/iio/adc/meson_saradc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > >> index 81cd39a57fe3..fb3f67a9ae1f 100644 > >> --- a/drivers/iio/adc/meson_saradc.c > >> +++ b/drivers/iio/adc/meson_saradc.c > >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) > >> if (!meson_sar_adc_get_fifo_count(indio_dev)) > >> break; > >> > >> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); > >> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); > >> } > >> } > >> > > > > Regards, > Martin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-06-03 8:52 ` Jonathan Cameron @ 2017-06-04 13:32 ` Martin Blumenstingl 2017-06-06 9:28 ` Paolo Cretaro 0 siblings, 1 reply; 7+ messages in thread From: Martin Blumenstingl @ 2017-06-04 13:32 UTC (permalink / raw) To: Jonathan Cameron; +Cc: Paolo Cretaro, linux-iio, linux-kernel Hi Paolo, Hi Jonathan, On Sat, Jun 3, 2017 at 10:52 AM, Jonathan Cameron <jic23@kernel.org> wrote: > On Sun, 28 May 2017 23:17:57 +0200 > Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > >> Hi Paolo, Hi Jonathan, >> >> On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@kernel.org> wrote: >> > On Sun, 28 May 2017 13:24:38 +0200 >> > Paolo Cretaro <paolocretaro@gmail.com> wrote: >> > >> >> Fix sparse warning: Using plain integer as NULL pointer >> >> >> >> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> >> > This looks fine to me, but ideally you should always try to include >> > the driver author - particularly in the case of patches to a recent >> > driver such as this one. >> > >> > To that end I've cc'd Martin. >> thanks for spotting this (and providing a patch to fix it) >> this looks good to me, so: >> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> >> if you can wait until next weekend then I can also test this on real hardware. > I've applied it to the togreg branch of iio.git but as that always goes out > as testing for at least a few days first (which I will happily rebase) give > me a shout if anything goes wrong! I have tested this on actual hardware and it seems that there's a bug in the meson-saradc driver (before and after this patch): if there are still "old" values in the FIFO then the driver currently crashes because regmap_read (regmap_mmio_read in case of the meson-saradc driver to be precise) de-references the "value" pointer (the parameter which we're trying to clean up here) -> this leads to a NULL de-reference. this happens regardless of whether we are passing "0" or "NULL" I posted a patch which fixes the crash - and as a bonus this should also fix the sparse warning reported by Paolo: http://lists.infradead.org/pipermail/linux-amlogic/2017-June/003863.html > Jonathan >> >> > Jonathan >> >> --- >> >> drivers/iio/adc/meson_saradc.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> >> index 81cd39a57fe3..fb3f67a9ae1f 100644 >> >> --- a/drivers/iio/adc/meson_saradc.c >> >> +++ b/drivers/iio/adc/meson_saradc.c >> >> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) >> >> if (!meson_sar_adc_get_fifo_count(indio_dev)) >> >> break; >> >> >> >> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); >> >> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); >> >> } >> >> } >> >> >> > >> >> Regards, >> Martin > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer 2017-06-04 13:32 ` Martin Blumenstingl @ 2017-06-06 9:28 ` Paolo Cretaro 0 siblings, 0 replies; 7+ messages in thread From: Paolo Cretaro @ 2017-06-06 9:28 UTC (permalink / raw) To: Martin Blumenstingl; +Cc: Jonathan Cameron, linux-iio, linux-kernel Il 04/06/2017 15:32, Martin Blumenstingl ha scritto: > Hi Paolo, Hi Jonathan, > > On Sat, Jun 3, 2017 at 10:52 AM, Jonathan Cameron <jic23@kernel.org> wrote: >> On Sun, 28 May 2017 23:17:57 +0200 >> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: >> >>> Hi Paolo, Hi Jonathan, >>> >>> On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@kernel.org> wrote: >>>> On Sun, 28 May 2017 13:24:38 +0200 >>>> Paolo Cretaro <paolocretaro@gmail.com> wrote: >>>> >>>>> Fix sparse warning: Using plain integer as NULL pointer >>>>> >>>>> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com> >>>> This looks fine to me, but ideally you should always try to include >>>> the driver author - particularly in the case of patches to a recent >>>> driver such as this one. >>>> >>>> To that end I've cc'd Martin. >>> thanks for spotting this (and providing a patch to fix it) >>> this looks good to me, so: >>> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> >>> if you can wait until next weekend then I can also test this on real hardware. >> I've applied it to the togreg branch of iio.git but as that always goes out >> as testing for at least a few days first (which I will happily rebase) give >> me a shout if anything goes wrong! > I have tested this on actual hardware and it seems that there's a bug > in the meson-saradc driver (before and after this patch): > if there are still "old" values in the FIFO then the driver currently > crashes because regmap_read (regmap_mmio_read in case of the > meson-saradc driver to be precise) de-references the "value" pointer > (the parameter which we're trying to clean up here) -> this leads to a > NULL de-reference. this happens regardless of whether we are passing > "0" or "NULL" > > I posted a patch which fixes the crash - and as a bonus this should > also fix the sparse warning reported by Paolo: > http://lists.infradead.org/pipermail/linux-amlogic/2017-June/003863.html Nice, thanks! Paolo > >> Jonathan >>> >>>> Jonathan >>>>> --- >>>>> drivers/iio/adc/meson_saradc.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >>>>> index 81cd39a57fe3..fb3f67a9ae1f 100644 >>>>> --- a/drivers/iio/adc/meson_saradc.c >>>>> +++ b/drivers/iio/adc/meson_saradc.c >>>>> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev) >>>>> if (!meson_sar_adc_get_fifo_count(indio_dev)) >>>>> break; >>>>> >>>>> - regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0); >>>>> + regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL); >>>>> } >>>>> } >>>>> >>>> >>> >>> Regards, >>> Martin >> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-06 9:28 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-28 11:24 [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro 2017-05-28 14:43 ` Jonathan Cameron 2017-05-28 17:52 ` Paolo Cretaro 2017-05-28 21:17 ` Martin Blumenstingl 2017-06-03 8:52 ` Jonathan Cameron 2017-06-04 13:32 ` Martin Blumenstingl 2017-06-06 9:28 ` Paolo Cretaro
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).