From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Matt Ranostay <matt.ranostay@konsulko.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2] iio: proximity: as3935: noise detection + threshold changes
Date: Sat, 3 Jun 2017 10:00:49 +0100 [thread overview]
Message-ID: <20170603100049.02fa3c76@kernel.org> (raw)
In-Reply-To: <20170530213259.qbcikyy446g726pk@rob-hp-laptop>
On Tue, 30 May 2017 16:32:59 -0500
Rob Herring <robh@kernel.org> wrote:
> On Sun, May 28, 2017 at 04:58:30PM +0100, Jonathan Cameron wrote:
> > On Wed, 24 May 2017 22:52:29 -0700
> > Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> >
> > > Most applications are too noisy to allow the default noise and
> > > watchdog settings, and thus need to be configurable via DT
> > > properties.
> > >
> > > Also default settings to POR defaults on a reset, and register
> > > distuber interrupts as noise since it prevents proper usage.
> > >
> > > Cc: devicetree@vger.kernel.org
> > > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> > I wonder if there are many other devices where this sort of
> > feature is relevant. Anyone else come across any?
> >
> > I suppose if we need to modify the ABI for any that show up
> > in future, it shouldn't be too hard to maintain this one
> > for backwards compatibility.
> >
> > Anyhow, new devicetree bindings so I'll give Rob / Mark time
> > to have a chance to look at it.
>
> I acked v1.
Given there are a couple of precursors working their way towards
mainline and stable, I'll need to wait for those to filter through.
Matt give me a bump if it looks like I've forgotten this once
it will apply!
Thanks,
Jonathan
>
> > My immediate thought is that you might be able to do something
> > a little more user (i.e. devicetree writer) friendly than
> > just using the register value...
>
> We certainly don't want that to be the norm, but sometimes it makes
> sense when it's very specific to a certain device.
>
> > I see there are values, but it depends on whether the device
> > is in 'indoor mode' or 'outdoor mode' (which are just gain
> > settings?). You could just use them though.
> >
> > Given the gain is userspace controlled, and seems to effect
> > the meaning of this setting, is it valid to just put it
> > in the devicetree?
next prev parent reply other threads:[~2017-06-03 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 5:52 [PATCH v2] iio: proximity: as3935: noise detection + threshold changes Matt Ranostay
2017-05-28 15:58 ` Jonathan Cameron
2017-05-30 21:32 ` Rob Herring
2017-06-03 9:00 ` Jonathan Cameron [this message]
2017-09-25 18:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603100049.02fa3c76@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt.ranostay@konsulko.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).