From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:44250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdFCJnk (ORCPT ); Sat, 3 Jun 2017 05:43:40 -0400 Date: Sat, 3 Jun 2017 10:37:37 +0100 From: Jonathan Cameron To: Sebastian Reichel , Sebastian Reichel , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jean Delvare , Guenter Roeck Cc: J Keerthy , linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] iio: adc: twl4030: Unexport twl4030_madc_conversion() Message-ID: <20170603103737.139206f6@kernel.org> In-Reply-To: <7eb96b68-71a7-361f-d14c-542a823f96b8@kernel.org> References: <20170427153012.32310-1-sebastian.reichel@collabora.co.uk> <20170427153012.32310-5-sebastian.reichel@collabora.co.uk> <7eb96b68-71a7-361f-d14c-542a823f96b8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sun, 30 Apr 2017 17:35:47 +0100 Jonathan Cameron wrote: > On 27/04/17 16:30, Sebastian Reichel wrote: > > All madc users have been converted to IIO API, so drop the > > legacy API. The function is still used inside of the driver. > > > > Signed-off-by: Sebastian Reichel > Acked-by: Jonathan Cameron Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with them. thanks, Jonathan > > --- > > drivers/iio/adc/twl4030-madc.c | 5 +++-- > > include/linux/i2c/twl4030-madc.h | 2 -- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > > index 88e44066ef82..be60f76d1a50 100644 > > --- a/drivers/iio/adc/twl4030-madc.c > > +++ b/drivers/iio/adc/twl4030-madc.c > > @@ -72,6 +72,8 @@ struct twl4030_madc_data { > > u8 isr; > > }; > > > > +static int twl4030_madc_conversion(struct twl4030_madc_request *req); > > + > > static int twl4030_madc_read(struct iio_dev *iio_dev, > > const struct iio_chan_spec *chan, > > int *val, int *val2, long mask) > > @@ -568,7 +570,7 @@ static int twl4030_madc_wait_conversion_ready(struct twl4030_madc_data *madc, > > * be a negative error value in the corresponding array element. > > * returns 0 if succeeds else error value > > */ > > -int twl4030_madc_conversion(struct twl4030_madc_request *req) > > +static int twl4030_madc_conversion(struct twl4030_madc_request *req) > > { > > const struct twl4030_madc_conversion_method *method; > > int ret; > > @@ -640,7 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) > > > > return ret; > > } > > -EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > > > /** > > * twl4030_madc_set_current_generator() - setup bias current > > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h > > index 0c919ebb31e0..be9260e261ac 100644 > > --- a/include/linux/i2c/twl4030-madc.h > > +++ b/include/linux/i2c/twl4030-madc.h > > @@ -141,6 +141,4 @@ struct twl4030_madc_user_parms { > > int status; > > u16 result; > > }; > > - > > -int twl4030_madc_conversion(struct twl4030_madc_request *conv); > > #endif > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html