From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Robert Dolca <robert.dolca@intel.com>,
Denis CIOCCA <denis.ciocca@st.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi@st.com>
Subject: Re: [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support
Date: Tue, 20 Jun 2017 17:40:37 +0100 [thread overview]
Message-ID: <20170620174037.657b47e4@kernel.org> (raw)
In-Reply-To: <CAA2SeNKKQM-zsg_8ieaiJbCCsjnPYgQMAds9tafiQHTyrO4fww@mail.gmail.com>
On Tue, 20 Jun 2017 13:54:30 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:
> > On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
> > <lorenzo.bianconi83@gmail.com> wrote:
> >
> >> Add proper support for L3GD20H gyroscope sensor. In particular:
> >> - use L3GD20H as device name instead of L3GD20
> >> - fix available full scales
> >> - fix available sample frequencies
> >>
> >> Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope)
> >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
> >
>
> Hi Linus,
>
> > Is this then fixing the issue papered over by
> > commit a0657716416f834ef7710a9044614d50a36c3bdc
> > "iio:gyro: bug on L3GD20H gyroscope support"
> > ?
> >
> > Then we should probably state that as a Fixes: too.
>
> The sensor support was introduce in 496822c78236 (iio:gyro: Add
> STMicroelectronics gyroscopes driver).
> Commit a0657716416 just removes the support since it was not properly done.
> So what do you think?
> We can add Fixes: 496822c78236 (iio:gyro: Add STMicroelectronics
> gyroscopes driver).
> Jonathan should I send a v2?
Don't worry. I've added the fixes tag and applied it.
I've also added a paragraph explaining what is going on with the two fixes
tags.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> Regards,
> Lorenzo
>
>
> >
> > Yours,
> > Linus Walleij
>
>
>
next prev parent reply other threads:[~2017-06-20 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:04 [PATCH 0/2] fix L3GD20H gyroscope sensor support Lorenzo Bianconi
2017-06-19 20:04 ` [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support Lorenzo Bianconi
2017-06-20 11:28 ` Linus Walleij
2017-06-20 11:54 ` Lorenzo Bianconi
2017-06-20 16:40 ` Jonathan Cameron [this message]
2017-06-19 20:04 ` [PATCH 2/2] dt-bindings: iio: gyro: add L3GD20H sensor device binding Lorenzo Bianconi
2017-06-20 11:29 ` Linus Walleij
2017-06-20 16:41 ` Jonathan Cameron
2017-06-23 21:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620174037.657b47e4@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo.bianconi@st.com \
--cc=robert.dolca@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).