From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:42630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbdFTQkn (ORCPT ); Tue, 20 Jun 2017 12:40:43 -0400 Date: Tue, 20 Jun 2017 17:40:37 +0100 From: Jonathan Cameron To: Lorenzo Bianconi Cc: Linus Walleij , Robert Dolca , Denis CIOCCA , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , Lorenzo Bianconi Subject: Re: [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support Message-ID: <20170620174037.657b47e4@kernel.org> In-Reply-To: References: <20170619200431.9615-1-lorenzo.bianconi@st.com> <20170619200431.9615-2-lorenzo.bianconi@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, 20 Jun 2017 13:54:30 +0200 Lorenzo Bianconi wrote: > > On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi > > wrote: > > > >> Add proper support for L3GD20H gyroscope sensor. In particular: > >> - use L3GD20H as device name instead of L3GD20 > >> - fix available full scales > >> - fix available sample frequencies > >> > >> Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope) > >> Signed-off-by: Lorenzo Bianconi > > > > Hi Linus, > > > Is this then fixing the issue papered over by > > commit a0657716416f834ef7710a9044614d50a36c3bdc > > "iio:gyro: bug on L3GD20H gyroscope support" > > ? > > > > Then we should probably state that as a Fixes: too. > > The sensor support was introduce in 496822c78236 (iio:gyro: Add > STMicroelectronics gyroscopes driver). > Commit a0657716416 just removes the support since it was not properly done. > So what do you think? > We can add Fixes: 496822c78236 (iio:gyro: Add STMicroelectronics > gyroscopes driver). > Jonathan should I send a v2? Don't worry. I've added the fixes tag and applied it. I've also added a paragraph explaining what is going on with the two fixes tags. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > Regards, > Lorenzo > > > > > > Yours, > > Linus Walleij > > >