[PATCH 0/2] fix L3GD20H gyroscope sensor support

[PATCH 0/2] fix L3GD20H gyroscope sensor support

[Lorenzo Bianconi]

Lorenzo Bianconi (2):
  iio: gyro: st_gyro: fix L3GD20H support
  dt-bindings: iio: gyro: add L3GD20H sensor device binding

 Documentation/devicetree/bindings/iio/st-sensors.txt |  1 +
 drivers/iio/gyro/st_gyro.h                           |  1 +
 drivers/iio/gyro/st_gyro_core.c                      | 13 +++++++------
 drivers/iio/gyro/st_gyro_i2c.c                       |  5 +++++
 drivers/iio/gyro/st_gyro_spi.c                       |  1 +
 5 files changed, 15 insertions(+), 6 deletions(-)

-- 
2.13.1

[PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support

[Lorenzo Bianconi]

Add proper support for L3GD20H gyroscope sensor. In particular:
- use L3GD20H as device name instead of L3GD20
- fix available full scales
- fix available sample frequencies

Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
---
 drivers/iio/gyro/st_gyro.h      |  1 +
 drivers/iio/gyro/st_gyro_core.c | 13 +++++++------
 drivers/iio/gyro/st_gyro_i2c.c  |  5 +++++
 drivers/iio/gyro/st_gyro_spi.c  |  1 +
 4 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/gyro/st_gyro.h b/drivers/iio/gyro/st_gyro.h
index a5c5c4e29add..48923ae6ac3b 100644
--- a/drivers/iio/gyro/st_gyro.h
+++ b/drivers/iio/gyro/st_gyro.h
@@ -19,6 +19,7 @@
 #define LSM330DL_GYRO_DEV_NAME		"lsm330dl_gyro"
 #define LSM330DLC_GYRO_DEV_NAME		"lsm330dlc_gyro"
 #define L3GD20_GYRO_DEV_NAME		"l3gd20"
+#define L3GD20H_GYRO_DEV_NAME		"l3gd20h"
 #define L3G4IS_GYRO_DEV_NAME		"l3g4is_ui"
 #define LSM330_GYRO_DEV_NAME		"lsm330_gyro"
 #define LSM9DS0_GYRO_DEV_NAME		"lsm9ds0_gyro"
diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c
index 2a42b3d583e8..e366422e8512 100644
--- a/drivers/iio/gyro/st_gyro_core.c
+++ b/drivers/iio/gyro/st_gyro_core.c
@@ -35,6 +35,7 @@
 #define ST_GYRO_DEFAULT_OUT_Z_L_ADDR		0x2c
 
 /* FULLSCALE */
+#define ST_GYRO_FS_AVL_245DPS			245
 #define ST_GYRO_FS_AVL_250DPS			250
 #define ST_GYRO_FS_AVL_500DPS			500
 #define ST_GYRO_FS_AVL_2000DPS			2000
@@ -196,17 +197,17 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = {
 		.wai = 0xd7,
 		.wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS,
 		.sensors_supported = {
-			[0] = L3GD20_GYRO_DEV_NAME,
+			[0] = L3GD20H_GYRO_DEV_NAME,
 		},
 		.ch = (struct iio_chan_spec *)st_gyro_16bit_channels,
 		.odr = {
 			.addr = 0x20,
 			.mask = 0xc0,
 			.odr_avl = {
-				{ .hz = 95, .value = 0x00, },
-				{ .hz = 190, .value = 0x01, },
-				{ .hz = 380, .value = 0x02, },
-				{ .hz = 760, .value = 0x03, },
+				{ .hz = 100, .value = 0x00, },
+				{ .hz = 200, .value = 0x01, },
+				{ .hz = 400, .value = 0x02, },
+				{ .hz = 800, .value = 0x03, },
 			},
 		},
 		.pw = {
@@ -224,7 +225,7 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = {
 			.mask = 0x30,
 			.fs_avl = {
 				[0] = {
-					.num = ST_GYRO_FS_AVL_250DPS,
+					.num = ST_GYRO_FS_AVL_245DPS,
 					.value = 0x00,
 					.gain = IIO_DEGREE_TO_RAD(8750),
 				},
diff --git a/drivers/iio/gyro/st_gyro_i2c.c b/drivers/iio/gyro/st_gyro_i2c.c
index 40056b821036..3f628746cb93 100644
--- a/drivers/iio/gyro/st_gyro_i2c.c
+++ b/drivers/iio/gyro/st_gyro_i2c.c
@@ -41,6 +41,10 @@ static const struct of_device_id st_gyro_of_match[] = {
 		.data = L3GD20_GYRO_DEV_NAME,
 	},
 	{
+		.compatible = "st,l3gd20h-gyro",
+		.data = L3GD20H_GYRO_DEV_NAME,
+	},
+	{
 		.compatible = "st,l3g4is-gyro",
 		.data = L3G4IS_GYRO_DEV_NAME,
 	},
@@ -95,6 +99,7 @@ static const struct i2c_device_id st_gyro_id_table[] = {
 	{ LSM330DL_GYRO_DEV_NAME },
 	{ LSM330DLC_GYRO_DEV_NAME },
 	{ L3GD20_GYRO_DEV_NAME },
+	{ L3GD20H_GYRO_DEV_NAME },
 	{ L3G4IS_GYRO_DEV_NAME },
 	{ LSM330_GYRO_DEV_NAME },
 	{ LSM9DS0_GYRO_DEV_NAME },
diff --git a/drivers/iio/gyro/st_gyro_spi.c b/drivers/iio/gyro/st_gyro_spi.c
index fbf2faed501c..fa14d8f2170d 100644
--- a/drivers/iio/gyro/st_gyro_spi.c
+++ b/drivers/iio/gyro/st_gyro_spi.c
@@ -52,6 +52,7 @@ static const struct spi_device_id st_gyro_id_table[] = {
 	{ LSM330DL_GYRO_DEV_NAME },
 	{ LSM330DLC_GYRO_DEV_NAME },
 	{ L3GD20_GYRO_DEV_NAME },
+	{ L3GD20H_GYRO_DEV_NAME },
 	{ L3G4IS_GYRO_DEV_NAME },
 	{ LSM330_GYRO_DEV_NAME },
 	{ LSM9DS0_GYRO_DEV_NAME },
-- 
2.13.1

Re: [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support

[Linus Walleij]

On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
<lorenzo.bianconi83@gmail.com> wrote:

> Add proper support for L3GD20H gyroscope sensor. In particular:
> - use L3GD20H as device name instead of L3GD20
> - fix available full scales
> - fix available sample frequencies
>
> Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>

Is this then fixing the issue papered over by
commit a0657716416f834ef7710a9044614d50a36c3bdc
"iio:gyro: bug on L3GD20H gyroscope support"
?

Then we should probably state that as a Fixes: too.

Yours,
Linus Walleij

Re: [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support

[Lorenzo Bianconi]

> On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
> <lorenzo.bianconi83@gmail.com> wrote:
>
>> Add proper support for L3GD20H gyroscope sensor. In particular:
>> - use L3GD20H as device name instead of L3GD20
>> - fix available full scales
>> - fix available sample frequencies
>>
>> Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope)
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
>

Hi Linus,

> Is this then fixing the issue papered over by
> commit a0657716416f834ef7710a9044614d50a36c3bdc
> "iio:gyro: bug on L3GD20H gyroscope support"
> ?
>
> Then we should probably state that as a Fixes: too.

The sensor support was introduce in 496822c78236 (iio:gyro: Add
STMicroelectronics gyroscopes driver).
Commit a0657716416 just removes the support since it was not properly done.
So what do you think?
We can add Fixes: 496822c78236 (iio:gyro: Add STMicroelectronics
gyroscopes driver).
Jonathan should I send a v2?

Regards,
Lorenzo


>
> Yours,
> Linus Walleij



-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep

Re: [PATCH 1/2] iio: gyro: st_gyro: fix L3GD20H support

[Jonathan Cameron]

On Tue, 20 Jun 2017 13:54:30 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:

> > On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
> > <lorenzo.bianconi83@gmail.com> wrote:
> >  
> >> Add proper support for L3GD20H gyroscope sensor. In particular:
> >> - use L3GD20H as device name instead of L3GD20
> >> - fix available full scales
> >> - fix available sample frequencies
> >>
> >> Fixes: 9444a300c2be (IIO: Add support for L3GD20H gyroscope)
> >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>  
> >  
> 
> Hi Linus,
> 
> > Is this then fixing the issue papered over by
> > commit a0657716416f834ef7710a9044614d50a36c3bdc
> > "iio:gyro: bug on L3GD20H gyroscope support"
> > ?
> >
> > Then we should probably state that as a Fixes: too.  
> 
> The sensor support was introduce in 496822c78236 (iio:gyro: Add
> STMicroelectronics gyroscopes driver).
> Commit a0657716416 just removes the support since it was not properly done.
> So what do you think?
> We can add Fixes: 496822c78236 (iio:gyro: Add STMicroelectronics
> gyroscopes driver).
> Jonathan should I send a v2?
Don't worry.  I've added the fixes tag and applied it.

I've also added a paragraph explaining what is going on with the two fixes
tags.  

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> 
> Regards,
> Lorenzo
> 
> 
> >
> > Yours,
> > Linus Walleij  
> 
> 
> 

[PATCH 2/2] dt-bindings: iio: gyro: add L3GD20H sensor device binding

[Lorenzo Bianconi]

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
---
 Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt
index eaa8fbba34e2..e31457ae6f50 100644
--- a/Documentation/devicetree/bindings/iio/st-sensors.txt
+++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
@@ -52,6 +52,7 @@ Gyroscopes:
 - st,lsm330dl-gyro
 - st,lsm330dlc-gyro
 - st,l3gd20-gyro
+- st,l3gd20h-gyro
 - st,l3g4is-gyro
 - st,lsm330-gyro
 - st,lsm9ds0-gyro
-- 
2.13.1

Re: [PATCH 2/2] dt-bindings: iio: gyro: add L3GD20H sensor device binding

[Linus Walleij]

On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
<lorenzo.bianconi83@gmail.com> wrote:

> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH 2/2] dt-bindings: iio: gyro: add L3GD20H sensor device binding

[Jonathan Cameron]

On Tue, 20 Jun 2017 13:29:33 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, Jun 19, 2017 at 10:04 PM, Lorenzo Bianconi
> <lorenzo.bianconi83@gmail.com> wrote:
> 
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>  
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij

Re: [PATCH 2/2] dt-bindings: iio: gyro: add L3GD20H sensor device binding

[Rob Herring]

On Mon, Jun 19, 2017 at 10:04:31PM +0200, Lorenzo Bianconi wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
> ---
>  Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>