From: Jonathan Cameron <jic23@kernel.org>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: <nicolas.ferre@microchip.com>,
<alexandre.belloni@free-electrons.com>,
<linux-iio@vger.kernel.org>, <lars@metafoo.de>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ludovic.desroches@microchip.com>, <robh@kernel.org>
Subject: Re: [PATCH v5 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin
Date: Tue, 20 Jun 2017 17:55:52 +0100 [thread overview]
Message-ID: <20170620175552.2ec49c56@kernel.org> (raw)
In-Reply-To: <1497533097-12052-2-git-send-email-eugen.hristev@microchip.com>
On Thu, 15 Jun 2017 16:24:54 +0300
Eugen Hristev <eugen.hristev@microchip.com> wrote:
> Enable pinctrl for ADTRG pin (PD31) for ADC hardware trigger support.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
The driver changes are on their way upstream.
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 0bef9e0..04754b1 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -303,7 +303,7 @@
> vddana-supply = <&vdd_3v3_lp_reg>;
> vref-supply = <&vdd_3v3_lp_reg>;
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_adc_default>;
> + pinctrl-0 = <&pinctrl_adc_default &pinctrl_adtrg_default>;
> status = "okay";
> };
>
> @@ -322,6 +322,20 @@
> bias-disable;
> };
>
> + /*
> + * The ADTRG pin can work on any edge type.
> + * In here it's being pulled up, so need to
> + * connect it to ground to get an edge e.g.
> + * Trigger can be configured on falling, rise
> + * or any edge, and the pull-up can be changed
> + * to pull-down or left floating according to
> + * needs.
> + */
> + pinctrl_adtrg_default: adtrg_default {
> + pinmux = <PIN_PD31__ADTRG>;
> + bias-pull-up;
> + };
> +
> pinctrl_charger_chglev: charger_chglev {
> pinmux = <PIN_PA12__GPIO>;
> bias-disable;
next prev parent reply other threads:[~2017-06-20 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 13:24 [PATCH v5 0/4] iio: adc: sama5d2_adc hw triggers and buffers Eugen Hristev
2017-06-15 13:24 ` [PATCH v5 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin Eugen Hristev
2017-06-20 16:55 ` Jonathan Cameron [this message]
2017-06-21 7:50 ` Nicolas Ferre
2017-06-15 13:24 ` [PATCH v5 2/4] Documentation: dt: iio: at91-sama5d2_adc: add hw trigger edge binding Eugen Hristev
2017-06-20 16:53 ` Jonathan Cameron
2017-06-15 13:24 ` [PATCH v5 3/4] ARM: dts: at91: sama5d2: add ADC hw trigger edge type Eugen Hristev
2017-06-20 16:56 ` Jonathan Cameron
2017-06-21 7:51 ` Nicolas Ferre
2017-06-15 13:24 ` [PATCH v5 4/4] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support Eugen Hristev
2017-06-20 16:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620175552.2ec49c56@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).