From: Jonathan Cameron <jic23@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lee Jones <lee.jones@linaro.org>, Marek Vasut <marex@denx.de>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: adc: mxs-lradc: Checking IS_ERR() instead of NULL
Date: Wed, 21 Jun 2017 20:15:12 +0100 [thread overview]
Message-ID: <20170621201512.5808cc8a@kernel.org> (raw)
In-Reply-To: <20170613083905.7aiaxvfjg2ypkfq2@mwanda>
On Tue, 13 Jun 2017 11:39:05 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Apr 27, 2017 at 07:21:09AM +0100, Jonathan Cameron wrote:
> > On 26/04/17 22:03, Dan Carpenter wrote:
> > > devm_ioremap() returns NULL on error. It doesn't return error pointers.
> > >
> > > Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > Hi Dan,
> >
> > Already another patch for this under review. Open question there is whether
> > devm_ioremap_resource is the way to go instead.
> >
>
> I wasn't on that other thread... Nothing appears to have happened with
> this or the touchscreen bug either.
>
> regards,
> dan carpenter
I think I was just being a bit lax in actually pushing it out and sending
Greg a pull request.
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=1454e15bc28ba94aa5d6b31a83a42d5c03af2a6d
Thanks for following up on this.
Jonathan
>
>
prev parent reply other threads:[~2017-06-21 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 21:03 [PATCH] iio: adc: mxs-lradc: Checking IS_ERR() instead of NULL Dan Carpenter
2017-04-27 6:21 ` Jonathan Cameron
2017-06-13 8:39 ` Dan Carpenter
2017-06-21 19:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621201512.5808cc8a@kernel.org \
--to=jic23@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).