Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Reno Farnesi <nfarnesi4@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging: iio: ad7280a: add spaces around '-'
Date: Mon, 26 Jun 2017 17:48:28 +0100	[thread overview]
Message-ID: <20170626174828.7445f608@kernel.org> (raw)
In-Reply-To: <1498418147.3882.10.camel@gmail.com>

On Sun, 25 Jun 2017 15:15:47 -0400
Reno Farnesi <nfarnesi4@gmail.com> wrote:

> Fixes the following checkpatch check to improve readability.
> 
> CHECK: spaces preferred around that '-' (ctx:VxV)
> 
> Signed-off-by: Reno Farnesi <nfarnesi4@gmail.com>
False positive.  Not everything is what it seems ;)

Check what the macro does with that parameter...

Jonathan
> ---
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index d5ab83f0236d..d79e7746d351 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
> void *private)
>  }
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> -		in_voltage-voltage_thresh_low_value,
> +		in_voltage - voltage_thresh_low_value,
>  		0644,
>  		ad7280_read_channel_config,
>  		ad7280_write_channel_config,
>  		AD7280A_CELL_UNDERVOLTAGE);
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> -		in_voltage-voltage_thresh_high_value,
> +		in_voltage - voltage_thresh_high_value,
>  		0644,
>  		ad7280_read_channel_config,
>  		ad7280_write_channel_config,


      reply	other threads:[~2017-06-26 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 19:15 [PATCH] staging: iio: ad7280a: add spaces around '-' Reno Farnesi
2017-06-26 16:48 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626174828.7445f608@kernel.org \
    --to=jic23@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=nfarnesi4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox