From: Jonathan Cameron <jic23@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values
Date: Sun, 9 Jul 2017 18:10:23 +0100 [thread overview]
Message-ID: <20170709181023.54458b6c@kernel.org> (raw)
In-Reply-To: <0ba9b76f-41f8-3171-2eb7-d9abbe106674@axentia.se>
On Fri, 7 Jul 2017 11:26:35 +0200
Peter Rosin <peda@axentia.se> wrote:
> On 2017-07-07 06:57, Peter Rosin wrote:
> > On 2017-07-07 06:53, Gustavo A. R. Silva wrote:
> >> Check return values from call to devm_kzalloc() and devm_kmemup()
> >
> > If someone cares enough: s/devm_kmemup/evm_kmemdup/
>
> Strange, there seems to be some inherent shortage of 'd' characters...
>
> Cheers,
> pea :-)
>
> >
> >> in order to prevent a NULL pointer dereference.
> >>
> >> This issue was detected using Coccinelle and the following semantic patch:
> >>
> >> @@
> >> expression x;
> >> identifier fld;
> >> @@
> >>
> >> * x = devm_kzalloc(...);
> >> ... when != x == NULL
> >> x->fld
> >>
> >> Cc: Peter Rosin <peda@axentia.se>
> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> >
> > Either way,
> >
> > Reviewed-by: Peter Rosin <peda@axentia.se>
> >
> > Thanks!
> >
The relevant patch adding the file in questions hasn't yet worked it's
way back to the iio tree so I can't apply this until it does.
That is likely to be a few weeks away yet. Please give me a poke if
I seem to have forgotten it!
Jonathan
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-09 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 22:08 [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() return value Gustavo A. R. Silva
2017-07-07 4:07 ` Peter Rosin
2017-07-07 4:35 ` Gustavo A. R. Silva
2017-07-07 4:46 ` Peter Rosin
2017-07-07 4:51 ` Gustavo A. R. Silva
2017-07-07 4:53 ` [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values Gustavo A. R. Silva
2017-07-07 4:57 ` Peter Rosin
2017-07-07 9:26 ` Peter Rosin
2017-07-09 17:10 ` Jonathan Cameron [this message]
2017-07-10 19:44 ` Gustavo A. R. Silva
2017-08-26 6:09 ` Peter Rosin
2017-09-03 12:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170709181023.54458b6c@kernel.org \
--to=jic23@kernel.org \
--cc=garsilva@embeddedor.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).