* [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read [not found] <20170714092540.1217397-1-arnd@arndb.de> @ 2017-07-14 9:31 ` Arnd Bergmann 2017-07-15 11:42 ` Jonathan Cameron 0 siblings, 1 reply; 2+ messages in thread From: Arnd Bergmann @ 2017-07-14 9:31 UTC (permalink / raw) To: linux-kernel, Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron, Greg Kroah-Hartman Cc: Linus Torvalds, Tejun Heo, Guenter Roeck, linux-ide, linux-media, akpm, dri-devel, Arnd Bergmann, stable, Hartmut Knaack, Peter Meerwald-Stadler, linux-iio, devel gcc-7 points out an older regression: drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw': drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] The original code had 'unsigned short' here, but incorrectly got converted to 'bool'. This reverts the regression and uses a normal type instead. Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec conversion.") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/iio/resolver/ad2s1210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index a6a8393d6664..3e00df74b18c 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -472,7 +472,7 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, long m) { struct ad2s1210_state *st = iio_priv(indio_dev); - bool negative; + u16 negative; int ret = 0; u16 pos; s16 vel; -- 2.9.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read 2017-07-14 9:31 ` [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read Arnd Bergmann @ 2017-07-15 11:42 ` Jonathan Cameron 0 siblings, 0 replies; 2+ messages in thread From: Jonathan Cameron @ 2017-07-15 11:42 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-kernel, Lars-Peter Clausen, Michael Hennerich, Greg Kroah-Hartman, Linus Torvalds, Tejun Heo, Guenter Roeck, linux-ide, linux-media, akpm, dri-devel, stable, Hartmut Knaack, Peter Meerwald-Stadler, linux-iio, devel On Fri, 14 Jul 2017 11:31:03 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > gcc-7 points out an older regression: > > drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw': > drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] > > The original code had 'unsigned short' here, but incorrectly got > converted to 'bool'. This reverts the regression and uses a normal > type instead. > > Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec conversion.") > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd, Applied to the fixes-togreg branch of iio.git. Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index a6a8393d6664..3e00df74b18c 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -472,7 +472,7 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, > long m) > { > struct ad2s1210_state *st = iio_priv(indio_dev); > - bool negative; > + u16 negative; > int ret = 0; > u16 pos; > s16 vel; ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-15 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170714092540.1217397-1-arnd@arndb.de>
2017-07-14 9:31 ` [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read Arnd Bergmann
2017-07-15 11:42 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).