* [PATCH] iio: adc: ina219: Avoid underflow for sleeping time
@ 2017-07-26 21:32 Stefan Brüns
2017-07-30 13:50 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Brüns @ 2017-07-26 21:32 UTC (permalink / raw)
To: linux-iio
Cc: linux-kernel, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Stefan Brüns
Proper support for the INA219 lowered the minimum sampling period from
2*140us to 2*84us. Subtracting 200us later leads to an underflow and
an almost infinite udelay later.
Using a signed int for the sampling period provides sufficient range
(at most 2*8640*1024us), but catches the underflow when comparing with
buffer_us.
Fixes: 18edac2e22f4 ("iio: adc: Fix integration time/averaging for INA219/220")
Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
---
drivers/iio/adc/ina2xx-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index b0d9e3b80e6d..85b419ea9ba9 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -657,7 +657,7 @@ static int ina2xx_capture_thread(void *data)
{
struct iio_dev *indio_dev = data;
struct ina2xx_chip_info *chip = iio_priv(indio_dev);
- unsigned int sampling_us = SAMPLING_PERIOD(chip);
+ int sampling_us = SAMPLING_PERIOD(chip);
int buffer_us;
/*
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: ina219: Avoid underflow for sleeping time
2017-07-26 21:32 [PATCH] iio: adc: ina219: Avoid underflow for sleeping time Stefan Brüns
@ 2017-07-30 13:50 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-07-30 13:50 UTC (permalink / raw)
To: Stefan Brüns
Cc: linux-iio, linux-kernel, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
On Wed, 26 Jul 2017 23:32:06 +0200
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> Proper support for the INA219 lowered the minimum sampling period from
> 2*140us to 2*84us. Subtracting 200us later leads to an underflow and
> an almost infinite udelay later.
>
> Using a signed int for the sampling period provides sufficient range
> (at most 2*8640*1024us), but catches the underflow when comparing with
> buffer_us.
>
> Fixes: 18edac2e22f4 ("iio: adc: Fix integration time/averaging for INA219/220")
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/adc/ina2xx-adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index b0d9e3b80e6d..85b419ea9ba9 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -657,7 +657,7 @@ static int ina2xx_capture_thread(void *data)
> {
> struct iio_dev *indio_dev = data;
> struct ina2xx_chip_info *chip = iio_priv(indio_dev);
> - unsigned int sampling_us = SAMPLING_PERIOD(chip);
> + int sampling_us = SAMPLING_PERIOD(chip);
> int buffer_us;
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-30 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-26 21:32 [PATCH] iio: adc: ina219: Avoid underflow for sleeping time Stefan Brüns
2017-07-30 13:50 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).